Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#10816 closed task (fixed)

CSS cleanup

Reported by: bill Owned by: bill
Priority: high Milestone: 1.5
Component: Dijit Version: 1.4.0
Keywords: Cc:
Blocked By: Blocking:

Description (last modified by bill)

Ticket to do various CSS cleanup of dijit.css and the themes, including:

  • remove unnecessarily long selectors
  • remove vestigal rules
  • rearrange rules so that rules for each widget are together
  • move cursor rules from themes to dijit.css

Change History (22)

comment:1 Changed 9 years ago by bill

Description: modified (diff)

comment:2 Changed 9 years ago by bill

(In [21472]) Fix invalid rule, refs #10816. (Margin can't be none, only 0.)

comment:3 Changed 9 years ago by bill

(In [21473]) Shorten some (unnecessarily) long selectors, refs #10816.

comment:4 Changed 9 years ago by bill

(In [21475]) Dialog tundra CSS cleanup including:

  • shortening selectors
  • removing commented out CSS
  • removed the webkit shadow for Menu because it wasn't being done correctly and actually it wasn't showing up; shadow should be specified on .dijitPopup (affecting all drop downs and popups, not just menu), with an exception for tooltip since it isn't rectangular.

Refs #10816.

comment:5 Changed 9 years ago by bill

(In [21476]) Move definition for toolbar separator icon from Editor.css to Toolbar.css, so that toolbar users don't need to include Editor.css.

It's sort of in the middle though since the actual icon is in the editor sprite.

Refs #10816.

comment:6 Changed 9 years ago by bill

(In [21485]) Cleanup Tree CSS, Refs #10816.

comment:7 Changed 9 years ago by bill

(In [21486]) Various tundra CSS cleanup, refs #10816.

comment:8 Changed 9 years ago by bill

(In [21487]) Various tundra form CSS cleanup, including:

  • moved all the spinner rules into the spinner file
  • since all input widgets have dijitTextBox class, we can simplify selectors
  • define border width for ComboBox? and Spinner buttons in dijit.css, so all theme needs to do is to specify color in normal mode and focus mode
  • a combo/spinner arrow button being active doesn't affect the border color; i think that rule was just there out of fear the dijitTextBoxFocused class wouldn't be set while the button was being pressed... but it is.
  • etc.

Refs #10816.

comment:9 Changed 9 years ago by bill

(In [21488]) Minor tundra layout CSS cleanup, refs #10816.

comment:10 Changed 9 years ago by bill

(In [21500]) Minor tundra CSS cleanup b/c dijitTextBox class is applied to all textbox based widgets including ComboBox and !Spinner, refs #10816.

comment:11 Changed 9 years ago by bill

(In [21541]) Comment about <h1> margin is no longer valid, so remove it and also remove the TitlePane double border on tundra, and some other CSS simplification. Refs #10816 !strict.

comment:12 Changed 9 years ago by bill

(In [21612]) Add comments and move Spinner RTL rule into dijit_rtl.css (it was the only one not there), refs #10816.

comment:13 Changed 9 years ago by bill

(In [21613]) Simplify spinner/a11y CSS a bit, and make it display better (in a11y mode), so that borders don't get cut off and arrows are a bit bigger. Refs #10816.

comment:14 Changed 9 years ago by bill

(In [21614]) Remove some FF workaround code that's apparently no longer needed, although hard to confirm since there is no record of why it was needed to begin with. Refs #2803, #10816.

comment:15 Changed 9 years ago by bill

(In [21615]) Remove vestigal rule, currently there's no node with tabStripMenuButton class. Refs #10816.

comment:16 Changed 9 years ago by bill

(In [21630]) Fix tundra RTL Select and simplify rules by using border-collapse rather than explicitly controlling which sides gets borders. Refs #10816 !strict.

comment:17 Changed 9 years ago by bill

(In [21632]) Fix vertical slider labels on FF so the tick mark are next to the groove and the numbers are on the outside. I think I'm removing workaround code that was just needed for FF2. Refs #10816.

comment:18 Changed 9 years ago by bill

(In [21659]) Simplify textbox CSS since all <input> widgets now get dijitTextBox class. Also consolidating the rules. Refs #10816.

comment:19 Changed 9 years ago by bill

(In [21660]) Consolidating all the rules for each widget. Refs #10816.

comment:20 Changed 9 years ago by bill

(In [21662]) dijitIEFixedToolbar is defined in dijit.css, no need to put it in each theme, refs #10816.

comment:21 Changed 9 years ago by bill

Resolution: fixed
Status: newclosed

comment:22 Changed 9 years ago by bill

(In [22057]) General CSS cleanup from Doug's work on #11034, refs #10816.

Note: See TracTickets for help on using tickets.