Opened 11 years ago
Closed 11 years ago
#10812 closed defect (invalid)
dojo.style() problem
Reported by: | dwight | Owned by: | anonymous |
---|---|---|---|
Priority: | high | Milestone: | tbd |
Component: | General | Version: | 1.4.0 |
Keywords: | dojo style | Cc: | |
Blocked By: | Blocking: |
Description
I think I found a bug in Dojo v1.4.0 (20973), the dojo.style() function:
line 5895 of the uncompressed file is:
String | Number */ |
..and I believe it should be:
String | Number */ |
That is, it is missing some parentheses. It tries to use _toStyleValue() function regardless of returned 's' style object
note: pardon the l's for vertical bars...
Change History (3)
comment:1 Changed 11 years ago by
comment:2 Changed 11 years ago by
Could you attach a test case that shows how the function is failing? That would help to make sure we are fixing the right thing, and make sure it does not break in the future.
comment:3 Changed 11 years ago by
Resolution: | → invalid |
---|---|
Status: | new → closed |
Please reopen with a test case/test dojo.style() call that does not work and is fixed by the suggested change.
Note: See
TracTickets for help on using
tickets.
Also, FireFox? 3.5.8 for Linux:
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.8) Gecko/20100214 Ubuntu/9.10 (karmic) Firefox/3.5.8 GTB6
FF complains about 's' object variable being null, although other browsers don't. I changed line 5888 from: var s = gcs(n);
to: var s = gcs(n) ll {};
...which stopped the error message.
I guess I should add that the original suggested change is my best guess of what was suppose to be the the way dojo.style() should work, but I could be missing something.