Opened 10 years ago

Closed 10 years ago

#10808 closed defect (fixed)

custom template on dojox.image.Lightbox

Reported by: minobun Owned by: dante
Priority: high Milestone: 1.5
Component: Dojox Version: 1.4.0
Keywords: Cc:
Blocked By: Blocking:

Description

Problem: I changed the position of the lightboxFooter in my lightbox template. For me the navigation itemes are now after not before the image. On the first image all is ok but if i click next the navigation is - like in the original template - after the image.

Solution: Lightbox.js around line 234

		if(this._wasStyled){
			// ugly fix for IE being stupid:
			dojo.destroy(_t.imgNode);
			_t.imgNode = dojo.create("img", null, _t.imageContainer, 'first');
			_t._makeAnims();
			_t._wasStyled = false;
		}

change to:

		if(this._wasStyled){
			// less ugly fix for ie being stupid:
			var tmpImgNode = dojo.create("img", null, _t.imgNode, 'after');
			dojo.destroy(_t.imgNode);
			_t.imgNode = tmpImgNode;
			_t._makeAnims();
			_t._wasStyled = false;
		}

Change History (3)

comment:1 Changed 10 years ago by Adam Peller

Component: GeneralDojox
Milestone: 1.4.2tbd
Owner: changed from anonymous to dante

comment:2 Changed 10 years ago by dante

Milestone: tbd1.5
Status: newassigned

comment:3 Changed 10 years ago by dante

Resolution: fixed
Status: assignedclosed

(In [21598]) fixes #10808 - allowing the template to be overridden by adjusting how the 'tmp' image is replaced back into the lightbox. previously it was appended to a containerNode, but now will be placed relative to the existing img node prior to its destruction.

fixes #10254 - adding in Lightbox.destroy to unregister an image from the master Dialog and adding a programatic way for items to be removed from a master Dialog by inference. (matching .href and .group members)

fixes #10538 - the css changes from _CssStateMixin caused the .dojoxLightbox classes to be overridden. making them more specific (avoiding !important) seems to reapply the padding and maintains overflow:hidden

Note: See TracTickets for help on using tickets.