Changes between Initial Version and Version 4 of Ticket #10799


Ignore:
Timestamp:
Mar 2, 2010, 4:28:46 PM (11 years ago)
Author:
bill
Comment:

I think that will work, it's just hackish because it's mixing the parser's job and the Widget's job. (It seems like the parser should delete jsId since it created it.) But I suppose things are tangled up already since (as I said) the parser creates the widgets, but they are destroyed manually.

The other thing is that ItemFileReadStore (as mentioned in the ticket description) does not extend dijit._Widget.

Anyway, I'm not sure that we want to have anything built in to remove the variable, but I'll think about it some more. Maybe the parser should return some kind of destruction meta-data to the ContentPane so that it can remove all the globals.

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #10799

    • Property Milestone changed from tbd to 1.6
  • Ticket #10799 – Description

    initial v4  
    1 It would appear that when the 'jsId="somevar"' in a declarative dojo Object, dojo properly creates the variable, but when the Object is destroyed, for example a dojo.data.ItemFileReadStore on a dijit.layout.ContentPane that is part of dijit.layout.TabContainer is closed, the Object is destoryed, but the global variable is not deleted, meaning that because not all references to the Object are removed, the Object is not removed from memory.
     1It would appear that when the 'jsId="somevar"' in a declarative dojo Object, dojo properly creates the variable, but when the Object is destroyed, for example a dojo.data.!ItemFileReadStore on a dijit.layout.!ContentPane that is part of dijit.layout.!TabContainer is closed, the Object is destroyed, but the global variable is not deleted, meaning that because not all references to the Object are removed, the Object is not removed from memory.
    22
    33Redeclaring the same Object with the same ID and jsId does not cause any issues or errors, as well as doing a native js "delete somevar;" after destruction does remove the Object from the DOM.