dijit._editor.RichText focus() bug

[Phil DeJarnett]

If one calls dijit.Editor.focus() on a non-IE before the editor gets properly initialized, dijit.Editor throws an error stating that this.editNode is NULL (not an object).

The error is due to this line in dijit/_editor/RichText.js:

927	focus: function(){
928		// summary:
929		//		Move focus to this editor
930		if(!dojo.isIE){
931			dijit.focus(this.iframe);
932			if(this._cursorToStart){ 
933				delete this._cursorToStart;
934				if(this.editNode.childNodes && 
-----------------------------------^^^^^^^^^^^^^^^^^^^^^^^^

Simply changing this line to include a check against this.editNode would fix the bug.

Alternatively, since the check is needed on both browsers, the contents for the entire function could be wrapped in

if(this.editNode) {
	// contents
}

And the check could be removed from the IE half.

(Note this error occurs under 1.4.1, but there isn't a bug reporting option for 1.4.1.)

[Jared Jurkiewicz]

You shouldn't call focus befor editor initialization has completed. You can avoid such by:

editor.onLoadDeferred.addCallback(function(){

editor.focus();

});

[Jared Jurkiewicz]

This is fixed in an alternative way in 1.5

if(!this.isLoaded){

this.focusOnLoad = true; return;

}

...

Closing