Opened 9 years ago

Last modified 3 years ago

#10774 assigned defect

[patch]Selecting dropped option in dNd MultiSelect widget

Reported by: Goran Miskovic Owned by:
Priority: high Milestone: 1.15
Component: DnD Version: 1.4.0
Keywords: dijit, MuliSelect, dNd Cc:
Blocked By: Blocking:

Description (last modified by Eugene Lazutkin)

Target is created from dijit.form.MultiSelect. Source is defined in markup on the top of div tag using dojo.dnd.Source (from test_dnd.html example).

Expected result:

Drop some item(s) on the select widget. Behavior of dropped item(s)/option(s) does not differ from the behavior of options defined in markup.

Actual result:

Dropped options cannot be selected using Google Chrome. Actually there is a workaround. One needs to set focus on the select widget and then dropped option can be selected/unselected. Problem is not present in FireFox.

Tested in Google Chrome 5.0.322.2 dev and FireFox 3.5.8 on Ubuntu Karmic Koala x64.

Attachments (2)

dNdChrome.html (6.0 KB) - added by Goran Miskovic 9 years ago.
Example updated to Dojo 1.4.3
Selector.js.patch (867 bytes) - added by Goran Miskovic 9 years ago.
Sniffing for WebKit?

Download all attachments as: .zip

Change History (11)

comment:1 Changed 9 years ago by Eugene Lazutkin

Milestone: tbdfuture
Status: newassigned

comment:2 Changed 9 years ago by Goran Miskovic

I was not able to figure the source of the problem but you will find attached hack.

For some reason Chrome, comparing to Firefox, is not reseting this.current to null.

My best guess is that problem is somewhere in handling mouse events. If you give me a hint how to efficiently trace mouse event I might be able to supply a patch.

comment:3 Changed 9 years ago by Eugene Lazutkin

Description: modified (diff)

comment:4 Changed 9 years ago by Eugene Lazutkin

Kind of a hacky patch --- it relies on the Chrome sniffing (is this problem present in any other WebKit-based browsers?), and special-cases OPTION. In any case, if it is a Chrome-related problem, it should be filed as bug with the Chrome team. Please do so, and post the ticket number here, so we can track it, and remove fixes, when it was resolved.

comment:5 Changed 9 years ago by Goran Miskovic

I told you: It is a hack. :)

Checking if it is OPTION tag is not necessary but I did not want to brake other cases if it is only 'dijit.form.MultiSelect?' related problem.

Problem is present in Epiphany 2.30.2 and Safari 5.0.1 (7533.17.8) running on Windows XP (Virtualbox) as well. I updated patch to sniff for WebKit? based browsers. I have also updated the example to use Dojo 1.4.3

I filed bug against WebKit? https://bugs.webkit.org/show_bug.cgi?id=43331

Changed 9 years ago by Goran Miskovic

Attachment: dNdChrome.html added

Example updated to Dojo 1.4.3

Changed 9 years ago by Goran Miskovic

Attachment: Selector.js.patch added

Sniffing for WebKit?

comment:6 Changed 7 years ago by Eugene Lazutkin

Summary: Selecting dropped option in dNd MultiSelect widget[patch]Selecting dropped option in dNd MultiSelect widget

comment:7 Changed 3 years ago by dylan

Milestone: future1.12
Owner: Eugene Lazutkin deleted

Need to review patch, see if there's a better fix, determine if the issue is still a problem, etc. Candidate for 1.12.

comment:8 Changed 3 years ago by Goran Miskovic

Six years later I doubt that it makes sense to waste time on this one. :)

Problem is ancient: Tested in Google Chrome 5.0.322.2 dev and FireFox? 3.5.8 on Ubuntu Karmic Koala x64. Dealing with it is more like archeological research. ;)

comment:9 Changed 3 years ago by dylan

Milestone: 1.131.15

Ticket planning... move current 1.13 tickets out to 1.15 to make it easier to move tickets into the 1.13 milestone.

Note: See TracTickets for help on using tickets.