Opened 10 years ago

Closed 4 years ago

#10758 closed enhancement (patchwelcome)

InlineEditBox: set editors width to match original (view-mode) width

Reported by: Craig Baker Owned by: bill
Priority: low Milestone: 1.13
Component: Dijit Version: 1.4.0
Keywords: dijit InlineEditBox width Cc:
Blocked By: Blocking:

Description (last modified by bill)

The _inlineEditor subclass needs the width argument to know how to set it's width, but the inlineEditBox class doesn't pay attention to the width argument, so it must be styled. It would be better if one of the two arguments weren't needed (either the _inlineEditor reads off of the style or the inlineEditBox sets its style off of the width argument).

new dijit.InlineEditBox({
   title: "Label",
   renderAsHtml: true, 
   style: 'width: 200px', 
   width: 200
},this.labelEdit);

Change History (10)

comment:1 Changed 10 years ago by Craig Baker

Putting this in the postMixinProperities function (around line 125) fixed it for me.

if(this.width){

dojo.style(this.displayNode, 'width', this.width + 'px');

}

comment:2 Changed 9 years ago by Douglas Hays

Owner: set to Douglas Hays

comment:3 Changed 9 years ago by Douglas Hays

Owner: changed from Douglas Hays to bill

This is related to [10824]. I think the preferred dijit way of sizing elements is thru CSS, but the width attribute is apparently needed for IE. Also I think dojo.position (that we didn't have back in 1.0) could have been used to properly compute the size of a SPAN on IE and thus have been able to size the editor widget properly, so maybe an explicit width won't be needed in the future.

comment:4 Changed 9 years ago by bill

Milestone: tbd1.7

comment:5 Changed 9 years ago by bill

Description: modified (diff)

comment:6 Changed 8 years ago by bill

Milestone: 1.71.8

running out of time for 1.7

comment:7 Changed 7 years ago by Colin Snover

Milestone: 1.82.0

1.8 is frozen. Move all enhancements to next release. If you need an exemption from the freeze for this ticket, contact me immediately.

comment:8 Changed 7 years ago by bill

Summary: dijit.InlineEditBox not using width argumentInlineEditBox: set editors width to match original (view-mode) width

comment:9 Changed 7 years ago by bill

Priority: highlow

comment:10 Changed 4 years ago by dylan

Milestone: 2.01.12
Resolution: patchwelcome
Status: newclosed

Given that no one has shown interest in creating a patch in the past 5+ years, I'm closing this as patchwelcome.

Note: See TracTickets for help on using tickets.