Opened 11 years ago
Closed 5 years ago
#10758 closed enhancement (patchwelcome)
InlineEditBox: set editors width to match original (view-mode) width
Reported by: | Craig Baker | Owned by: | bill |
---|---|---|---|
Priority: | low | Milestone: | 1.13 |
Component: | Dijit | Version: | 1.4.0 |
Keywords: | dijit InlineEditBox width | Cc: | |
Blocked By: | Blocking: |
Description (last modified by )
The _inlineEditor subclass needs the width argument to know how to set it's width, but the inlineEditBox class doesn't pay attention to the width argument, so it must be styled. It would be better if one of the two arguments weren't needed (either the _inlineEditor reads off of the style or the inlineEditBox sets its style off of the width argument).
new dijit.InlineEditBox({ title: "Label", renderAsHtml: true, style: 'width: 200px', width: 200 },this.labelEdit);
Change History (10)
comment:1 Changed 11 years ago by
comment:2 Changed 10 years ago by
Owner: | set to Douglas Hays |
---|
comment:3 Changed 10 years ago by
Owner: | changed from Douglas Hays to bill |
---|
This is related to [10824]. I think the preferred dijit way of sizing elements is thru CSS, but the width attribute is apparently needed for IE. Also I think dojo.position (that we didn't have back in 1.0) could have been used to properly compute the size of a SPAN on IE and thus have been able to size the editor widget properly, so maybe an explicit width won't be needed in the future.
comment:4 Changed 10 years ago by
Milestone: | tbd → 1.7 |
---|
comment:5 Changed 10 years ago by
Description: | modified (diff) |
---|
comment:7 Changed 9 years ago by
Milestone: | 1.8 → 2.0 |
---|
1.8 is frozen. Move all enhancements to next release. If you need an exemption from the freeze for this ticket, contact me immediately.
comment:8 Changed 9 years ago by
Summary: | dijit.InlineEditBox not using width argument → InlineEditBox: set editors width to match original (view-mode) width |
---|
comment:9 Changed 8 years ago by
Priority: | high → low |
---|
comment:10 Changed 5 years ago by
Milestone: | 2.0 → 1.12 |
---|---|
Resolution: | → patchwelcome |
Status: | new → closed |
Given that no one has shown interest in creating a patch in the past 5+ years, I'm closing this as patchwelcome.
Putting this in the postMixinProperities function (around line 125) fixed it for me.
if(this.width){
}