Opened 9 years ago

Closed 9 years ago

#10748 closed defect (fixed)

[patch][cla] dojox.widget.PlaceholderMenuItem does not destroy PopupMenuItem popups

Reported by: avoidscorn Owned by: dante
Priority: high Milestone: 1.6
Component: DojoX Widgets Version: 1.4.0
Keywords: Cc:
Blocked By: Blocking:

Description

PlaceholderMenuItem's unReplace method destroys its widgets via destroy instead of destroyRecursive. As a result, if one of those widgets is a dijit.PopupMenuItem, then that menu item's popup will not be destroyed.

The attached patch uses destroyRecursive instead of destroy and adds a test case to test_PlaceholderMenuItem.html.

Attachments (1)

PlaceholderMenuItem.patch (1.4 KB) - added by avoidscorn 9 years ago.
Fix and test case

Download all attachments as: .zip

Change History (4)

Changed 9 years ago by avoidscorn

Attachment: PlaceholderMenuItem.patch added

Fix and test case

comment:1 Changed 9 years ago by dante

Status: newassigned

comment:2 Changed 9 years ago by dante

Milestone: tbd1.6

comment:3 Changed 9 years ago by dante

Resolution: fixed
Status: assignedclosed

(In [22726]) fixes #10748 - Thanks for the quick fix and test, looks great.

Note: See TracTickets for help on using tickets.