Opened 9 years ago

Closed 6 years ago

#10734 closed defect (patchwelcome)

ComboBox as cell of DataGrid does not page correctly through options on ENTER key

Reported by: engshien Owned by: Evan
Priority: high Milestone: future
Component: DojoX Grid Version: 1.4.0
Keywords: Cc:
Blocked By: Blocking:

Description

Create dojox.grid.cells.ComboBox? with pageSize less than the number of options so that "More choices.." appears in the options list. If you select "More choices.." with a mouse click, it pages properly. However, if you select "More choices.." with the ENTER key, it does not page and you get the text "More choices..." as the value of the ComboBox?.

My analysis is that ComboBox? depends on getting the ENTER event to handle paging, but that onKeyDown in dojox.grid._Events stops ENTER from propagating to the ComboBox?.

My hack locally to get around this is to override DataGrid? onKeyDown:

dojo.declare("MyDataGrid?", dojox.grid.DataGrid?, {

onKeyDown: function(e) {

if (e.keyCode == dojo.keys.ENTER) {

return; let ENTER event propogate to ComboBox?

} this.inherited(arguments);

}

});

Of course, this hack is preventing the DataGrid? from seeing the ENTER event.

Change History (5)

comment:1 Changed 9 years ago by Nathan Toone

Owner: Nathan Toone deleted

Unassigning my tickets.

comment:2 Changed 8 years ago by evan

Milestone: tbdfuture
Owner: set to evan

comment:3 Changed 8 years ago by Evan

Owner: changed from evan to Evan

comment:4 Changed 6 years ago by bill

DojoX Grid and EnhancedGrid are deprecated in favor of dgrid and gridx.

You should upgrade your code to use one of those two grids.

We will consider patches to the old DojoX Grid code though.

comment:5 Changed 6 years ago by bill

Resolution: patchwelcome
Status: newclosed
Note: See TracTickets for help on using tickets.