Opened 10 years ago

Closed 4 years ago

#10732 closed defect (patchwelcome)

[patch][cla][needs amd conversion] dojox.gfx.Moveable used with delay can get into bad state

Reported by: steveshaw@… Owned by: Eugene Lazutkin
Priority: high Milestone: 1.13
Component: DojoX GFX Version: 1.4.0
Keywords: Cc:
Blocked By: Blocking:

Description

Steps:

  • Use dojox.gfx.Moveable on a shape and have a delay (a larger delay will cause this issue to be more prominant).
  • Drag quickly on the shape to the outside such that the mouse move interval exceeds the drag and then mouse-up outside of the shape.
  • move mouse back over the shape...

Result:

  • If you are handling the onFirstMove override, then you may be creating feedback while your mouse button is up. From the user standpoint they have released the mouse and the gesture should be over.

Expected:

  • Probably the move should be terminated when the mouse leaves the shape because the internal exceeded the delay.

I have attached a file with suggested changes in dojox.gfx.Moveable. Basically a handler for "onMouseLeave" has been added that checks if the move hasn't been started and calls this.onMouseUp to terminate the move.

Attachments (2)

Moveable.2.js (3.9 KB) - added by steveshaw@… 10 years ago.
Here is a suggested fix for the issue described in Moveable.js
Moveable.3.js (3.9 KB) - added by steveshaw@… 10 years ago.
small change to centralize setting of _delayInEffect to false

Download all attachments as: .zip

Change History (5)

Changed 10 years ago by steveshaw@…

Attachment: Moveable.2.js added

Here is a suggested fix for the issue described in Moveable.js

Changed 10 years ago by steveshaw@…

Attachment: Moveable.3.js added

small change to centralize setting of _delayInEffect to false

comment:1 Changed 10 years ago by Adam Peller

Component: GeneralDojoX GFX
Owner: changed from anonymous to Eugene Lazutkin

comment:2 Changed 9 years ago by Eugene Lazutkin

Milestone: tbdfuture
Status: newassigned

comment:3 Changed 4 years ago by dylan

Milestone: future1.12
Resolution: patchwelcome
Status: assignedclosed
Summary: dojox.gfx.Moveable used with delay can get into bad state[patch][cla][needs amd conversion] dojox.gfx.Moveable used with delay can get into bad state

This one has a very old patch, sorry that it was never reviewed 6 years ago. If someone wants to update it, we'll consider it for 1.12.

Note: See TracTickets for help on using tickets.