[patch][cla][needs amd conversion] dojox.gfx.Moveable used with delay can get into bad state

[steveshaw@…]

Steps:

• Use dojox.gfx.Moveable on a shape and have a delay (a larger delay will cause this issue to be more prominant).
• Drag quickly on the shape to the outside such that the mouse move interval exceeds the drag and then mouse-up outside of the shape.
• move mouse back over the shape...

Result:

• If you are handling the onFirstMove override, then you may be creating feedback while your mouse button is up. From the user standpoint they have released the mouse and the gesture should be over.

Expected:

• Probably the move should be terminated when the mouse leaves the shape because the internal exceeded the delay.

I have attached a file with suggested changes in dojox.gfx.Moveable. Basically a handler for "onMouseLeave" has been added that checks if the move hasn't been started and calls this.onMouseUp to terminate the move.

[steveshaw@…]

Here is a suggested fix for the issue described in Moveable.js

[steveshaw@…]

small change to centralize setting of _delayInEffect to false

[dylan]

This one has a very old patch, sorry that it was never reviewed 6 years ago. If someone wants to update it, we'll consider it for 1.12.