Changes between Initial Version and Version 1 of Ticket #10727


Ignore:
Timestamp:
Feb 11, 2010, 5:47:31 PM (11 years ago)
Author:
bill
Comment:

Shane, do we need the tab.onClick() calls in ScrollingTabController.onSelectChild()? They don't seem appropriate.

I tried commenting them out and then running:

dijit.byId("mainTabContainer").selectChild(dijit.byId("tab2"))
dijit.byId("mainTabContainer").selectChild(dijit.byId("tab1"))

from firebug, it seems to work.

Obviously the checked (aka selected) state of the TabButton's needs to change, so that the selected tab is white, but that's handled in StackController.onSelectChild().

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #10727

    • Property Owner set to Shane O'Sullivan
    • Property Summary changed from ScrollingTabContainer tab click calls selectChild twice to ScrollingTabContainer: tab click calls selectChild twice
  • Ticket #10727 – Description

    initial v1  
    11In test_TabContainer, click on any tab to select a new tab. If you put a log in selectChild, you'll see it gets called twice.  While it should not be catastrophic, some apps may not be expecting this condition and it can cause regressions.  Thanks to Phil Berkland @ IBM for spotting this.
    22
    3 StackController.onButtonClick calls container.selectChild.  That publishes an event which triggers onButtonClick a second time via ScrollingTabController.onSelectChild:280
     3!StackController.onButtonClick calls container.selectChild.  That publishes an event which triggers onButtonClick a second time via !ScrollingTabController.onSelectChild:280
    44
    55{{{