Opened 9 years ago

Closed 9 years ago

#10723 closed defect (duplicate)

dojo 1.4.1 dijit.layout.TabContainer missing sanity check for this.selectedChildWidget when doLayout is false

Reported by: shlomib2 Owned by:
Priority: high Milestone: tbd
Component: Dijit Version: 1.4.0
Keywords: TabContainer, this.selectedChildWidget, is not a function Cc:
Blocked By: Blocking:

Description

The internal "layout" function of TabContainer? class is missing a check if (this.selectedChildWidget) surrounding the line "this.selectedChildWidget.resize();" when this.doLayout is false

If this.doLayout is set to false, then on widget startup there is a chance for this.selectedChildWidget.resize(); to fail and throw an exception " this.selectedChildWidget is not a function", causing the tabs and contents not to load.

Adding that extra sanity check fixes this issue.

The missing if-clause needs to be added around line 116 of "layout" function inside "dijit/layout/_TabContainerBase.js"

This is only true for dojo release 1.4.1 and not 1.3.2 version

Change History (2)

comment:1 Changed 9 years ago by Adam Peller

dup of #10532?

comment:2 Changed 9 years ago by bill

Resolution: duplicate
Status: newclosed

Yup, and fixed in 1.4.2.

Note: See TracTickets for help on using tickets.