MenuBar: hovering MenuBarItem should make previously opened menu disappear immediately

[Pete Smith]

I have a menubar, with a combination of PopupMenuBarItems and MenuBarItems. If I hover over the popup menu bar item, a menu appears. If I hover over the adjoining MenuBarItem, the menu does not come down right away as it should. This does work if both items are popupmenuBarItems. I have the need to combine buttons as well as popup menu items on the same menubar, which this affords.

To Reproduce:

​http://download.dojotoolkit.org/release-1.4.1/dojo-release-1.4.1/dijit/tests/test_Menu.html

1. Click "Help" Menu. See popup come out.
2. Hover over "Disabled" (doesn't matter enabled or disabled). The menu has a delay in coming down.

It works perfectly if you go to ANOTHER popup menu. If you hover over a menuBar Item, the menu from the previous should knock down immediately.

[bill]

Hmm, when you say "come down" and "Knock down" do you mean "disappear"?

[bill]

Hmm, you must be talking about the delay in the help menu disappearing.

[bill]

Note that for vertical menus, the delay is intentional, because if the user slides diagonally from the PopupMenuItem to the popup Menu, he may hit other siblings of the PopupMenuItem along the way.

For MenuBar though I don't see a compelling reason to do the delay.

[bill]

In [30895]:

For active MenuBars, open and close submenus immediately. I.E. even if the previously hovered/focused MenuBarItem didn't have a menu, show the menu for the new PopupBarMenu immediately. And conversely, even if the new MenuBarItem doesn't have a menu, close the old menu immediately. Fixes #10721 !strict.

Also converted _markActive(), _markInactive(), and isActive flag to standard "activated" property with custom setter. Didn't call it "active" because that's already used by _CssStateMixin.

[bill]

In [30897]:

Just set popupDelay to 0 instead of having to override onItemHover(), refs #10721 !strict.