Opened 9 years ago

Closed 9 years ago

Last modified 6 years ago

#10719 closed defect (fixed)

[patch][ccla]IE: Removal of line inside dijit dialog fails

Reported by: Jared Jurkiewicz Owned by: bill
Priority: high Milestone: 1.5
Component: DojoX GFX Version: 1.4.0
Keywords: Cc: Douglas Hays
Blocked By: Blocking:

Description

Reported by a co-worker:

on 1.3.2: The removal of line fails in IE6 or IE7, if the line is drawn in a dialog box. Lines drawn outside the dialog remove successfully.

I have attached two sample html files to replicate the problem for the creation and removal of line with or without a dialog.

In first case the line is removed successfully but if the line is drawn on the dijit.Dialog it fails while trying to remove it.

Attachments (3)

lineDrawDialog.html (1.2 KB) - added by Jared Jurkiewicz 9 years ago.
Test showing failre in dialog
lineDraw.html (910 bytes) - added by Jared Jurkiewicz 9 years ago.
Alternate test without dialog
removeLine.patch (853 bytes) - added by Adam Peller 9 years ago.
patch from Li Yang (IBM, CCLA)

Download all attachments as: .zip

Change History (14)

Changed 9 years ago by Jared Jurkiewicz

Attachment: lineDrawDialog.html added

Test showing failre in dialog

Changed 9 years ago by Jared Jurkiewicz

Attachment: lineDraw.html added

Alternate test without dialog

comment:1 Changed 9 years ago by Eugene Lazutkin

Milestone: tbdfuture
Status: newassigned

comment:2 Changed 9 years ago by liyang

I made a patch for this and it shall show up here soon.

comment:3 Changed 9 years ago by Adam Peller

Milestone: futuretbd
Summary: GFX: IE: Removal of line inside dijit dialog fails[patch][ccla]IE: Removal of line inside dijit dialog fails

Changed 9 years ago by Adam Peller

Attachment: removeLine.patch added

patch from Li Yang (IBM, CCLA)

comment:4 Changed 9 years ago by Eugene Lazutkin

Cc: Douglas Hays added
Milestone: tbd1.5
Owner: changed from Eugene Lazutkin to bill
Status: assignednew

The patch modifies dijit._getTabNavigable() in dijit/_base/manager.js and doesn't touch dojox.gfx. While it looks fine to me, I reassign it to Bill and Doug to review and commit, if it looks ok to them too.

comment:5 Changed 9 years ago by bill

I can check in a slightly modified version of that, although it would be better if there was a way to detect non-HTML nodes for all browsers, so we can skip over SVG too. Is there an easy way?

comment:6 Changed 9 years ago by bill

Resolution: fixed
Status: newclosed

(In [22268]) When looking for focusable elements, skip over VML subtrees (as searching them causes an exception). In the future I'd like to implement a solution that skips over SVG subtrees too, for efficiency reasons.

Fixes #10719 !strict.

comment:7 Changed 6 years ago by bill

In [30083]:

Fix code to find tab navigable elements on IE10.

Refs #10719, fixes #16126 on trunk !strict

comment:8 Changed 6 years ago by bill

In [30084]:

Fix code to find tab navigable elements on IE10.

Refs #10719, fixes #16126 on 1.8 branch !strict

comment:9 Changed 6 years ago by bill

In [30085]:

Backport [30083] to 1.7 branch, restricting VML check to IE <= 9, refs #10719 and fixes #16123, #16124, #16126 on 1.7 branch !strict

comment:10 Changed 6 years ago by bill

In [30086]:

Backport [30083] to 1.6 branch, restricting VML check to IE <= 9, refs #10719 and fixes #16123, #16124, #16126 on 1.6 branch !strict

comment:11 Changed 6 years ago by bill

In [30087]:

Backport [30083] to 1.5 branch, restricting VML check to IE <= 9, refs #10719 and fixes #16123, #16124, #16126 on 1.5 branch !strict

Note: See TracTickets for help on using tickets.