Opened 10 years ago

Closed 7 years ago

Last modified 6 years ago

#10716 closed defect (fixed)

Menu: don't highlight first MenuItem on open via mouse click

Reported by: Pete Smith Owned by: bill
Priority: high Milestone: 1.8
Component: Dijit Version: 1.4.0
Keywords: Cc:
Blocked By: Blocking:

Description (last modified by bill)

When clicking a menu, the first item in the list should not be selected unless the menu was selected via a keyboard key. This is standard on all the OS's I tried. When clicking the menu, the first item should not be selected until the user hovers over it.

This is done on line 264 of Menu.js.

Change History (10)

comment:1 Changed 10 years ago by bill

Description: modified (diff)
Summary: Usability Standardization on Menus and MenuBarMenu: Usability Standardization on Menus and MenuBar

Hi Pete.

I guess the first one makes sense.

I'm not following you on the second one, what does "come down" mean? Obviously hovering over a MenuBarItem shouldn't display a menu, because there's no associated menu.

Also, every issue should be filed as a separate ticket.

comment:2 Changed 10 years ago by Pete Smith

OK Making a ticket out of the second one. Sorry for the protocol mistake.

comment:3 Changed 10 years ago by Pete Smith

http://bugs.dojotoolkit.org/ticket/10721

Created out of the second one.

comment:4 Changed 9 years ago by jhrabows

We run into Issue-1 in our company. A workaround was to subclass dijit.Menu and overwrite the focus() method which called _onFocus() to perform the initialization without actually focusing on the first node. A true solution could be done along these lines but with a configurable parameter.

comment:5 Changed 9 years ago by bill

Description: modified (diff)
Milestone: tbdfuture
Summary: Menu: Usability Standardization on Menus and MenuBarMenu: don't highlight first MenuItem on open via mouse click

comment:6 Changed 8 years ago by bill

Milestone: future1.8
Owner: set to bill
Status: newassigned

See also #14918.

comment:7 Changed 7 years ago by bill

Resolution: fixed
Status: assignedclosed

In [28210]:

Don't focus the first menu item when menu drop down is opened by a mouse click. Continue to focus the first menu item if menu is opened via the keyboard. Also, continue to focus the selected item in the dropdown list from a dijit.form.Select. Works around iOS problem on DropDownButton, ComboButton, and Menu/MenuBar where the first click on the drop down menu is ignored.

Refs #14918, fixes #10716 !strict.

comment:8 Changed 6 years ago by Bill Keese <bill@…>

In a9f0acc6264cc7803fec9002dc4f474e9ce8b11d/dijit:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:8 Changed 6 years ago by Bill Keese <bill@…>

In 8b0ef9502a811d0f9f240bc2afa5275fec218376/dijit:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:9 Changed 6 years ago by Bill Keese <bill@…>

In 2406766bd5c7b13977209fcab1b76aadf5c0e274/dijit:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 
Note: See TracTickets for help on using tickets.