Opened 10 years ago

Closed 9 years ago

#10683 closed defect (worksforme)

CSS optimization for dijit.css user file

Reported by: Adam Peller Owned by: James Burke
Priority: high Milestone: tbd
Component: BuildSystem Version: 1.4.0
Keywords: Cc: lbustelo@…
Blocked By: Blocking:

Description

From Gino Bustelo (IBM)

We have 2 css files

main.css
dijit.css

dijit.css is were we override some of the dojo theme styles specific to dijits. In main.css we have

@import url("dijit.css");

When the dojo build tries to internalize the content of dijit.css into main.css, it fails without any errors. The output just skips the internalizing of a file with the name dijit.css.

I don't see any special casing in the build for dijit.css, but perhaps the flattenCss is failing when filenames are not unique?

Change History (2)

comment:1 Changed 10 years ago by bill

IIRC dijit.css is special cased so that it doesn't get included three times if your page includes three themes. (Because tundra.css, soria.css, nihilo.css etc. all import dijit.css)

comment:2 Changed 9 years ago by James Burke

Resolution: worksforme
Status: newclosed

The dijit.css special casing is only done via build option setting for our specific release builds. It should inline the file normally, unless cssImportIgnore is set to contain dijit.css.

Please attach a sample build command with a build profile that demonstrates the problem.

Note: See TracTickets for help on using tickets.