Opened 10 years ago

Closed 9 years ago

#10680 closed enhancement (fixed)

[patch] [ccla]new GridContainer and GridContainerLite based on dojox.dnd

Reported by: jfcunat Owned by: Shane O'Sullivan
Priority: high Milestone: 1.6
Component: Dojox Version: 1.4.0
Keywords: dojox GridContainer Cc: dante
Blocked By: Blocking:

Description

Initial checkin of the replacement of dojox.layout.GridContainer? by two components using new dojox.dnd (see #10679)

  • GridContainerLite? that allows drag an drop of children inside a component with a configurable number of columns
  • GridContainer? that adds resizing columns and fixed columns to the Lite version

Attachments (8)

patch_GridContainer.txt (137.7 KB) - added by jfcunat 10 years ago.
patch_GridContainer_v0.2.txt (71.8 KB) - added by jfcunat 10 years ago.
some small fixes
patch_PortletTests_v0.1.txt (9.3 KB) - added by jfcunat 10 years ago.
patch for updating portlet in gridcontainer tests
GridContainer_and_tests.patch (161.1 KB) - added by Shane O'Sullivan 10 years ago.
Patch for the GridContainer? & tests. Checkstyle cleanup has been performed, and tested in IE6, IE7, IE8, FF3.6, Crome, Safari, Opera
Dojox_DND_tests_1.patch (25.7 KB) - added by Shane O'Sullivan 10 years ago.
Patch for the GridContainer? & tests. Checkstyle cleanup has been performed, and tested in IE6, IE7, IE8, FF3.6, Crome, Safari, Opera
Dojox_DND_tests_2.patch (65.6 KB) - added by Shane O'Sullivan 10 years ago.
Dojox_DND_Code.patch (94.1 KB) - added by Shane O'Sullivan 10 years ago.
Patch for the GridContainer? & tests. Checkstyle cleanup has been performed, and tested in IE6, IE7, IE8, FF3.6, Crome, Safari, Opera
gridcontainer_grip.gif (80 bytes) - added by Shane O'Sullivan 10 years ago.
Image to be placed in dojox/layout/resources/icons

Download all attachments as: .zip

Change History (20)

Changed 10 years ago by jfcunat

Attachment: patch_GridContainer.txt added

comment:1 Changed 10 years ago by Adam Peller

Component: GeneralDojox
Owner: changed from anonymous to dante

Changed 10 years ago by jfcunat

some small fixes

Changed 10 years ago by jfcunat

Attachment: patch_PortletTests_v0.1.txt added

patch for updating portlet in gridcontainer tests

comment:2 Changed 10 years ago by dante

Milestone: 1.51.6

Changed 10 years ago by Shane O'Sullivan

Patch for the GridContainer? & tests. Checkstyle cleanup has been performed, and tested in IE6, IE7, IE8, FF3.6, Crome, Safari, Opera

Changed 10 years ago by Shane O'Sullivan

Attachment: Dojox_DND_tests_1.patch added

Patch for the GridContainer? & tests. Checkstyle cleanup has been performed, and tested in IE6, IE7, IE8, FF3.6, Crome, Safari, Opera

Changed 10 years ago by Shane O'Sullivan

Attachment: Dojox_DND_tests_2.patch added

Changed 10 years ago by Shane O'Sullivan

Attachment: Dojox_DND_Code.patch added

Patch for the GridContainer? & tests. Checkstyle cleanup has been performed, and tested in IE6, IE7, IE8, FF3.6, Crome, Safari, Opera

Changed 10 years ago by Shane O'Sullivan

Attachment: gridcontainer_grip.gif added

Image to be placed in dojox/layout/resources/icons

comment:3 Changed 10 years ago by Shane O'Sullivan

I attached a number of patches, to get around the max patch size in trac. The following patches must be applied: GridContainer_and_tests.patch Dojox_DND_Code.patch Dojox_DND_tests_1.patch Dojox_DND_tests_2.patch

and the image fridcontainer_grip.gif should be placed in dojox/layout/resources/icons

If there are no objections to this, I will check it in to DojoX in the coming week.

comment:4 Changed 10 years ago by Shane O'Sullivan

Are there any objections to putting this into 1.5?

comment:5 Changed 10 years ago by Eugene Lazutkin

Cc: dante added
Milestone: 1.61.5
Owner: changed from dante to Eugene Lazutkin
Status: newassigned

Preparing to commit these patches in time for 1.5 beta.

comment:6 Changed 10 years ago by Eugene Lazutkin

Resolution: fixed
Status: assignedclosed

(In [21950]) Added new GridContainer? to use dojox.mdnd, thx Shane O'Sullivan!, !strict, fixes #10680.

comment:7 Changed 10 years ago by Eugene Lazutkin

Patches contain complete files instead of incremental changes => it added new versions to the top of old files. I resolved differences how I understood them and tests appear to work, but please double check me.

Related: #10679 (committed in [21949]).

comment:8 Changed 10 years ago by Mathevet julien

Resolution: fixed
Status: closedreopened

Could you restore getZone function in gridContainer. I used it. And to keep a backward compatibility

comment:9 Changed 10 years ago by Eugene Lazutkin

Owner: changed from Eugene Lazutkin to Shane O'Sullivan
Status: reopenednew

Reassigning to Shane --- he is the module owner.

comment:10 Changed 9 years ago by Adam Peller

Milestone: 1.51.6

comment:11 Changed 9 years ago by Shane O'Sullivan

(In [22759]) Refs #10680 Fixes the issue where the column attribute of the contained widgets was not being updated when dragged around the GridContainer?. Also adds the ability to retrieve a list of the zones in the GridContainer? !strict

comment:12 Changed 9 years ago by Shane O'Sullivan

Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.