Opened 11 years ago
Closed 5 years ago
#10677 closed enhancement (patchwelcome)
FilteringSelect: don't require options to have value attribute
Reported by: | jthg | Owned by: | |
---|---|---|---|
Priority: | high | Milestone: | 1.13 |
Component: | Dijit - Form | Version: | 1.4.0 |
Keywords: | Cc: | [email protected]… | |
Blocked By: | Blocking: |
Description (last modified by )
dijit.form.FilteringSelect does not initialize properly if the children option elements do not have the value attribute. Firefox 3.5 w/ Firebug has the following in the console: node is undefined - dojo.js, Line 16
The following codes fails:
<select dojoType="dijit.form.FilteringSelect" id="id1" name="name1"> <option>foo</option> <option>bar</option> <option>foobar</option> </select>
and, the following code succeeds in initializing the FilteringSelect?:
<select dojoType="dijit.form.FilteringSelect" id="id2" name="name2"> <option value="foo">foo</option> <option value="bar">bar</option> <option value="foobar">foobar</option> </select>
From what I can tell, value is not required in HTML; the value will default to the text content within the option tag. I would expect that to be the desired behaivor in Dojo.
Change History (8)
comment:1 Changed 11 years ago by
Milestone: | tbd → future |
---|---|
Summary: | FilteringSelect requires option to have value attribute → FilteringSelect: requires option to have value attribute |
comment:2 Changed 11 years ago by
yeah - I think want to be using FilteringSelect?. That test case above is a very simplified version of what I am working on!
comment:3 Changed 10 years ago by
Description: | modified (diff) |
---|---|
Summary: | FilteringSelect: requires option to have value attribute → FilteringSelect: don't require options to have value attribute |
Type: | defect → enhancement |
comment:4 Changed 10 years ago by
Owner: | set to Douglas Hays |
---|
comment:5 Changed 10 years ago by
Component: | Dijit → Dijit - Form |
---|
comment:6 Changed 7 years ago by
Owner: | Douglas Hays deleted |
---|---|
Status: | new → assigned |
comment:7 Changed 7 years ago by
Status: | assigned → open |
---|
comment:8 Changed 5 years ago by
Milestone: | future → 1.12 |
---|---|
Resolution: | → patchwelcome |
Status: | open → closed |
Given that no one has shown interest in creating a patch in the past 5+ years, I'm closing this as patchwelcome.
I guess so, although are you sure you don't want to be using ComboBox?