Opened 9 years ago

Closed 3 years ago

#10677 closed enhancement (patchwelcome)

FilteringSelect: don't require options to have value attribute

Reported by: jthg Owned by:
Priority: high Milestone: 1.13
Component: Dijit - Form Version: 1.4.0
Keywords: Cc: jthg@…
Blocked By: Blocking:

Description (last modified by bill)

dijit.form.FilteringSelect does not initialize properly if the children option elements do not have the value attribute. Firefox 3.5 w/ Firebug has the following in the console: node is undefined - dojo.js, Line 16

The following codes fails:

<select dojoType="dijit.form.FilteringSelect" id="id1" name="name1">
  <option>foo</option>
  <option>bar</option>
  <option>foobar</option>
</select>

and, the following code succeeds in initializing the FilteringSelect?:

<select dojoType="dijit.form.FilteringSelect" id="id2" name="name2">
  <option value="foo">foo</option>
  <option value="bar">bar</option>
  <option value="foobar">foobar</option>
</select>

From what I can tell, value is not required in HTML; the value will default to the text content within the option tag. I would expect that to be the desired behaivor in Dojo.

Change History (8)

comment:1 Changed 9 years ago by bill

Milestone: tbdfuture
Summary: FilteringSelect requires option to have value attributeFilteringSelect: requires option to have value attribute

I guess so, although are you sure you don't want to be using ComboBox?

comment:2 Changed 9 years ago by jthg

yeah - I think want to be using FilteringSelect?. That test case above is a very simplified version of what I am working on!

comment:3 Changed 9 years ago by bill

Description: modified (diff)
Summary: FilteringSelect: requires option to have value attributeFilteringSelect: don't require options to have value attribute
Type: defectenhancement

comment:4 Changed 8 years ago by Douglas Hays

Owner: set to Douglas Hays

comment:5 Changed 8 years ago by bill

Component: DijitDijit - Form

comment:6 Changed 5 years ago by Douglas Hays

Owner: Douglas Hays deleted
Status: newassigned

comment:7 Changed 5 years ago by Douglas Hays

Status: assignedopen

comment:8 Changed 3 years ago by dylan

Milestone: future1.12
Resolution: patchwelcome
Status: openclosed

Given that no one has shown interest in creating a patch in the past 5+ years, I'm closing this as patchwelcome.

Note: See TracTickets for help on using tickets.