FilteringSelect: "required" attribute broken for blank <option>

[Daniel Stefaniuk]

At the moment required attribute does not work with blank option. It is due to the isValid function not being coded properly.

The code is as follow:

isValid: function(){
	return this._isvalid || (!this.required && this.attr('displayedValue') == "");
},

however it should be:

isValid: function(){
	return this._isvalid && (!this.required || this.attr('displayedValue') != "");
},

[bill]

Is this a regression? Hopefully not. required is working in general but I guess you are speaking specifically about having a blank entry in the drop down.

[Douglas Hays]

If user input matches a datastore record, then it's valid by design. In the case of a blank record, then a valid item object is assigned and onChange is called with that value. The correct behavior is to specify value= on instantiation and not have a blank record in the datastore. Note that this scenario is currently not working but will be fixed in #10431.

[Douglas Hays]

#10431 has been fixed in trunk. value="" and required=true will cause the textbox to be blank and will create an error condition as long as there's no blank option in the datastore.