Opened 9 years ago

Last modified 3 years ago

#10644 assigned defect

dojox.form.BusyButton label can't be changed permanently

Reported by: mangelp Owned by: dylan
Priority: high Milestone: 1.15
Component: DojoX Form Version: 1.4.0
Keywords: BusyButton label Cc: mangelp@…
Blocked By: Blocking:

Description

BusyButton? makes a copy of the label at postCreate and each time the cancel method is called it restores that copy overwriting any change you could do to the button's label.

Attached are two patches, one with a possible fix and another with a test for this.

Attachments (2)

BusyButton.diff (1.3 KB) - added by mangelp 9 years ago.
Proposed patch for dojox.form.BusyButton?
test_BusyButton.diff (1.9 KB) - added by mangelp 9 years ago.
Proposed patch for dojox.form.BusyButton? tests

Download all attachments as: .zip

Change History (9)

Changed 9 years ago by mangelp

Attachment: BusyButton.diff added

Proposed patch for dojox.form.BusyButton?

Changed 9 years ago by mangelp

Attachment: test_BusyButton.diff added

Proposed patch for dojox.form.BusyButton? tests

comment:1 Changed 9 years ago by dante

Owner: changed from dante to jared_j

comment:2 Changed 9 years ago by Jared Jurkiewicz

Owner: jared_j deleted

comment:3 Changed 9 years ago by Jared Jurkiewicz

Not mine. Never worked on this widget

comment:4 Changed 9 years ago by Jared Jurkiewicz

Owner: set to nonken

Assigning to Nonken, he originally submitted it.

comment:6 Changed 3 years ago by dylan

Milestone: tbd1.12
Owner: changed from nonken to dylan
Status: newassigned

Will look at this and perhaps an updated patch for 1.12.

comment:7 Changed 3 years ago by dylan

Milestone: 1.131.15

Ticket planning... move current 1.13 tickets out to 1.15 to make it easier to move tickets into the 1.13 milestone.

Note: See TracTickets for help on using tickets.