Opened 9 years ago

Closed 9 years ago

#10637 closed enhancement (wontfix)

Dojox Drawing, PowerPoint functionality and a whole lot of other things

Reported by: Ace Sorensen Owned by: Mike Wilcox
Priority: high Milestone: 1.5
Component: Dojox Version: 1.4.0
Keywords: Cc: Tom Trenka
Blocked By: Blocking:

Description

This includes everything from PowerPoint? functionality (after drawing the tool is deselected which allows better drawing for modeling situations, like the Andes project) to a new svg for the equation tool to keypress panning, etc.

Attachments (3)

DojoxDrawingEnhancements.patch​ (18.1 KB) - added by Ace Sorensen 9 years ago.
DrawingUIToolbar.patch​ (521 bytes) - added by Ace Sorensen 9 years ago.
DojoxDrawingPointer.patch​ (1.8 KB) - added by Ace Sorensen 9 years ago.

Download all attachments as: .zip

Change History (12)

Changed 9 years ago by Ace Sorensen

Attachment: DojoxDrawingEnhancements.patch​ added

comment:1 Changed 9 years ago by Adam Peller

Cc: Mike Wilcox removed
Component: General → Dojox
Milestone: 1.4.1 → tbd
Owner: changed from anonymous to Mike Wilcox

comment:2 Changed 9 years ago by bill

Summary: Dojox Drawing, PowerPoint functionality and a whole lot of other things → [patch] [no cla] Dojox Drawing, PowerPoint functionality and a whole lot of other things

comment:3 Changed 9 years ago by Mike Wilcox

Summary: [patch] [no cla] Dojox Drawing, PowerPoint functionality and a whole lot of other things → Dojox Drawing, PowerPoint functionality and a whole lot of other things

Patches look good except for one mistake that I fixed. Asaelh has a CLA on file with SitePen?, and will be a big help in maintaining Drawing.

comment:4 Changed 9 years ago by Mike Wilcox

Resolution: → fixed
Status: new → closed

(In [21166]) Fixes #10637 - Applied Ace's patch. \!strict

comment:5 Changed 9 years ago by Ace Sorensen

Resolution: fixed
Status: closed → reopened

Thanks for applying! One small error in the the fix, this patch should fix it

Changed 9 years ago by Ace Sorensen

Attachment: DrawingUIToolbar.patch​ added

comment:6 Changed 9 years ago by Mike Wilcox

Resolution: → fixed
Status: reopened → closed

(In [21170]) Fixes #10637 - Again. Toolbar wasn't checking the clickmode.. \!strict

comment:7 Changed 9 years ago by bill

Milestone: tbd → 1.5

comment:8 Changed 9 years ago by Ace Sorensen

Resolution: fixed
Status: closed → reopened

This patch makes it so the cursor is default when in PowerPoint? mode and selecting, whereas it is crosshair while drawing. The original draw mode cursor states are unaffected. It also has the correct check for clickmode.

Changed 9 years ago by Ace Sorensen

Attachment: DojoxDrawingPointer.patch​ added

comment:9 Changed 9 years ago by Mike Wilcox

Resolution: → wontfix
Status: reopened → closed

Sorry Asaelh, I have to reject this for the following reasons:

  • That patch should be a new ticket
  • There were style violations (not using brackets for if-statements)
  • Documenting violations (not that Drawing was already perfect!)
  • The patch didn't work - though I tracked this down to a if-not that should be an if
Note: See TracTickets for help on using tickets.