Opened 11 years ago
Closed 11 years ago
#10637 closed enhancement (wontfix)
Dojox Drawing, PowerPoint functionality and a whole lot of other things
Reported by: | Ace Sorensen | Owned by: | Mike Wilcox |
---|---|---|---|
Priority: | high | Milestone: | 1.5 |
Component: | Dojox | Version: | 1.4.0 |
Keywords: | Cc: | Tom Trenka | |
Blocked By: | Blocking: |
Description
This includes everything from PowerPoint? functionality (after drawing the tool is deselected which allows better drawing for modeling situations, like the Andes project) to a new svg for the equation tool to keypress panning, etc.
Attachments (3)
Change History (12)
Changed 11 years ago by
Attachment: | DojoxDrawingEnhancements.patch added |
---|
comment:1 Changed 11 years ago by
Cc: | Mike Wilcox removed |
---|---|
Component: | General → Dojox |
Milestone: | 1.4.1 → tbd |
Owner: | changed from anonymous to Mike Wilcox |
comment:2 Changed 11 years ago by
Summary: | Dojox Drawing, PowerPoint functionality and a whole lot of other things → [patch] [no cla] Dojox Drawing, PowerPoint functionality and a whole lot of other things |
---|
comment:3 Changed 11 years ago by
Summary: | [patch] [no cla] Dojox Drawing, PowerPoint functionality and a whole lot of other things → Dojox Drawing, PowerPoint functionality and a whole lot of other things |
---|
comment:4 Changed 11 years ago by
Resolution: | → fixed |
---|---|
Status: | new → closed |
comment:5 Changed 11 years ago by
Resolution: | fixed |
---|---|
Status: | closed → reopened |
Thanks for applying! One small error in the the fix, this patch should fix it
Changed 11 years ago by
Attachment: | DrawingUIToolbar.patch added |
---|
comment:6 Changed 11 years ago by
Resolution: | → fixed |
---|---|
Status: | reopened → closed |
comment:7 Changed 11 years ago by
Milestone: | tbd → 1.5 |
---|
comment:8 Changed 11 years ago by
Resolution: | fixed |
---|---|
Status: | closed → reopened |
This patch makes it so the cursor is default when in PowerPoint? mode and selecting, whereas it is crosshair while drawing. The original draw mode cursor states are unaffected. It also has the correct check for clickmode.
Changed 11 years ago by
Attachment: | DojoxDrawingPointer.patch added |
---|
comment:9 Changed 11 years ago by
Resolution: | → wontfix |
---|---|
Status: | reopened → closed |
Sorry Asaelh, I have to reject this for the following reasons:
- That patch should be a new ticket
- There were style violations (not using brackets for if-statements)
- Documenting violations (not that Drawing was already perfect!)
- The patch didn't work - though I tracked this down to a if-not that should be an if
Note: See
TracTickets for help on using
tickets.
Patches look good except for one mistake that I fixed. Asaelh has a CLA on file with SitePen?, and will be a big help in maintaining Drawing.