Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#10630 closed defect (duplicate)

dijit._base.sniff: No way to identify Internet Explorer 8 via CSS class of the HTML tag?

Reported by: holgerthurow Owned by:
Priority: high Milestone: tbd
Component: Dijit Version: 1.3.2
Keywords: dijit._base.sniff, CSS, HEAD Cc:
Blocked By: Blocking:

Description

For Explorer 7 a additional class with version number is applied to the HTML tag like "dj_ie dj_ie7 ...". For Explorer 8 just "dj_ie ..." is applied. Because of this I don't know how to differentiate IE 8 and IE 7 by the class name.

Change History (5)

comment:1 Changed 10 years ago by holgerthurow

I inserted in dijit/_base/sniff

dj_ie8: maj(ie) == 8

after the line

dj_ie7: maj(ie) == 7

and now it is working.

comment:2 Changed 10 years ago by Adam Peller

Component: CoreDijit
Owner: anonymous deleted

getting away from csshacks could be a good thing :) but I guess we're stuck going forward with this?

comment:3 Changed 10 years ago by bill

Resolution: duplicate
Status: newclosed

Dup of #9053, fixed 10 months ago in [17194].

comment:4 Changed 10 years ago by holgerthurow

Which version is the patch included in? I checked out http://svn.dojotoolkit.org/src/tags/release-1.3.2 but couldn't see this change. svn log shows this info for that revision

"Using r18825 to create a tag for the 1.3.2 release."

If the change was committed in r17194 why can't I find it? The code looks still like

		classes = {
			dj_ie: ie,
//			dj_ie55: ie == 5.5,
			dj_ie6: maj(ie) == 6,
			dj_ie7: maj(ie) == 7,
			dj_iequirks: ie && d.isQuirks,

What do I wrong?

comment:5 Changed 10 years ago by bill

It's in 1.4. The key revision number is when we created the 1.3 branch, not when 1.3.2 was cut. Presumably 1.3 was branched before [17194].

Note: See TracTickets for help on using tickets.