#10630 closed defect (duplicate)
dijit._base.sniff: No way to identify Internet Explorer 8 via CSS class of the HTML tag?
Reported by: | holgerthurow | Owned by: | |
---|---|---|---|
Priority: | high | Milestone: | tbd |
Component: | Dijit | Version: | 1.3.2 |
Keywords: | dijit._base.sniff, CSS, HEAD | Cc: | |
Blocked By: | Blocking: |
Description
For Explorer 7 a additional class with version number is applied to the HTML tag like "dj_ie dj_ie7 ...". For Explorer 8 just "dj_ie ..." is applied. Because of this I don't know how to differentiate IE 8 and IE 7 by the class name.
Change History (5)
comment:1 Changed 11 years ago by
comment:2 Changed 11 years ago by
Component: | Core → Dijit |
---|---|
Owner: | anonymous deleted |
getting away from csshacks could be a good thing :) but I guess we're stuck going forward with this?
comment:3 Changed 11 years ago by
Resolution: | → duplicate |
---|---|
Status: | new → closed |
comment:4 Changed 11 years ago by
Which version is the patch included in?
I checked out http://svn.dojotoolkit.org/src/tags/release-1.3.2 but couldn't see this change.
svn log shows this info for that revision
"Using r18825 to create a tag for the 1.3.2 release."
If the change was committed in r17194 why can't I find it? The code looks still like
classes = { dj_ie: ie, // dj_ie55: ie == 5.5, dj_ie6: maj(ie) == 6, dj_ie7: maj(ie) == 7, dj_iequirks: ie && d.isQuirks,
What do I wrong?
comment:5 Changed 11 years ago by
It's in 1.4. The key revision number is when we created the 1.3 branch, not when 1.3.2 was cut. Presumably 1.3 was branched before [17194].
I inserted in dijit/_base/sniff
after the line
and now it is working.