Opened 13 years ago

Closed 13 years ago

#1062 closed enhancement (invalid)

[cla] [patch] DropDownTimePicker widget

Reported by: guest Owned by: dylan
Priority: low Milestone: 0.9
Component: General Version: 0.3
Keywords: timepicker dropdowntimepicker Cc: dojo@…, ktiedt@…
Blocked By: Blocking:

Description

I have coded a DropDownTimePicker? widget that I think would be useful to others. I will attach it to this ticket for checking. CLA has already been submitted.

Attachments (2)

dropdowntimepicker.2.zip (7.8 KB) - added by dojo@… 13 years ago.
Fixes IE error and hiding issues
dropdowntimepicker.zip (7.8 KB) - added by dojo@… 13 years ago.
Fixes IE error and hiding issues

Download all attachments as: .zip

Change History (11)

comment:1 Changed 13 years ago by guest

Forgot to put contact details! Contact details are:

Lance Duivenbode dojo AT duivenbode DOT id DOT au

comment:2 Changed 13 years ago by dylan

Owner: changed from anonymous to dylan
Status: newassigned

CLA verified...

Overall, we really appreciate the patch.

Unfortunately, there are a few minor problems with this patch before we can accept it:

  • I don't see the dropdown actually populating the parent, or an image for the dropdown button
  • Copyright notice shouldn't be in each file
  • Some places in the code use whitespace instead of tabs (for example, updateTimeField)
  • Some commented code... should this be in the patch or not
  • All new widgets should use the defineWidget syntax (we're slowly replacing the old ones)
  • addParseTreeHandler() call seems unnecessary
  • add test case to tests/widget/test_TimePicker.html

Also, I'm not really sure that I get what the difference between the normal TimePicker? and the PieTimePicker? widget is?

comment:3 Changed 13 years ago by Lance Duivenbode

Thanks for the feedback Dylan. I'll look at making those changes ASAP. I'll post the modified code back here when they are done.

Lance

comment:4 Changed 13 years ago by dylan

Milestone: 0.5

comment:5 Changed 13 years ago by bill

Summary: Addition of DropDownTimePicker widget[patch] DropDownTimePicker widget

Changed 13 years ago by dojo@…

Attachment: dropdowntimepicker.2.zip added

Fixes IE error and hiding issues

Changed 13 years ago by dojo@…

Attachment: dropdowntimepicker.zip added

Fixes IE error and hiding issues

comment:6 Changed 13 years ago by ornus

I'm looking forward to this widget being available with the dojo.

comment:7 Changed 13 years ago by tk

Keywords: timepicker dropdowntimepicker added
Summary: [patch] DropDownTimePicker widget[cla] [patch] DropDownTimePicker widget

comment:8 Changed 13 years ago by tk

Cc: dojo@… ktiedt@… added

Lance,

Can you update these changes to be congruent with the current structure of the widgets? (no /html/ directory and templates/css are just Widgetname.html/css. The reason behind this is that Html based widgets now extend widget/HtmlWidget.js

-Karl ps. a *.diff/*.patch file would be a better way to submit it as well, as it can be reviewed directly via the trac website.

comment:9 Changed 13 years ago by tk

Resolution: invalid
Status: assignedclosed

Actually, after reviewing this current code closer, this isn't an update to our current TimePicker? like I understood it to be. This ticket is resolved as we already have a functioning TimePicker? and DropdownTimePicker?.

-Karl

Note: See TracTickets for help on using tickets.