[cla] [patch] DropDownTimePicker widget

[guest]

I have coded a DropDownTimePicker? widget that I think would be useful to others. I will attach it to this ticket for checking. CLA has already been submitted.

[guest]

Forgot to put contact details! Contact details are:

Lance Duivenbode dojo AT duivenbode DOT id DOT au

[dylan]

CLA verified...

Overall, we really appreciate the patch.

Unfortunately, there are a few minor problems with this patch before we can accept it:

• I don't see the dropdown actually populating the parent, or an image for the dropdown button
• Copyright notice shouldn't be in each file
• Some places in the code use whitespace instead of tabs (for example, updateTimeField)
• Some commented code... should this be in the patch or not
• All new widgets should use the defineWidget syntax (we're slowly replacing the old ones)
• addParseTreeHandler() call seems unnecessary
• add test case to tests/widget/test_TimePicker.html

Also, I'm not really sure that I get what the difference between the normal TimePicker? and the PieTimePicker? widget is?

[Lance Duivenbode]

Thanks for the feedback Dylan. I'll look at making those changes ASAP. I'll post the modified code back here when they are done.

Lance

[dojo@…]

Fixes IE error and hiding issues

[dojo@…]

Fixes IE error and hiding issues

[ornus]

I'm looking forward to this widget being available with the dojo.

[tk]

Lance,

Can you update these changes to be congruent with the current structure of the widgets? (no /html/ directory and templates/css are just Widgetname.html/css. The reason behind this is that Html based widgets now extend widget/HtmlWidget.js

-Karl ps. a *.diff/*.patch file would be a better way to submit it as well, as it can be reviewed directly via the trac website.

[tk]

Actually, after reviewing this current code closer, this isn't an update to our current TimePicker? like I understood it to be. This ticket is resolved as we already have a functioning TimePicker? and DropdownTimePicker?.

-Karl