Opened 15 years ago
Closed 14 years ago
#1062 closed enhancement (invalid)
[cla] [patch] DropDownTimePicker widget
Reported by: | guest | Owned by: | dylan |
---|---|---|---|
Priority: | low | Milestone: | 0.9 |
Component: | General | Version: | 0.3 |
Keywords: | timepicker dropdowntimepicker | Cc: | [email protected]…, [email protected]… |
Blocked By: | Blocking: |
Description
I have coded a DropDownTimePicker? widget that I think would be useful to others. I will attach it to this ticket for checking. CLA has already been submitted.
Attachments (2)
Change History (11)
comment:1 Changed 15 years ago by
comment:2 Changed 15 years ago by
Owner: | changed from anonymous to dylan |
---|---|
Status: | new → assigned |
CLA verified...
Overall, we really appreciate the patch.
Unfortunately, there are a few minor problems with this patch before we can accept it:
- I don't see the dropdown actually populating the parent, or an image for the dropdown button
- Copyright notice shouldn't be in each file
- Some places in the code use whitespace instead of tabs (for example, updateTimeField)
- Some commented code... should this be in the patch or not
- All new widgets should use the defineWidget syntax (we're slowly replacing the old ones)
- addParseTreeHandler() call seems unnecessary
- add test case to tests/widget/test_TimePicker.html
Also, I'm not really sure that I get what the difference between the normal TimePicker? and the PieTimePicker? widget is?
comment:3 Changed 15 years ago by
Thanks for the feedback Dylan. I'll look at making those changes ASAP. I'll post the modified code back here when they are done.
Lance
comment:4 Changed 15 years ago by
Milestone: | → 0.5 |
---|
comment:5 Changed 15 years ago by
Summary: | Addition of DropDownTimePicker widget → [patch] DropDownTimePicker widget |
---|
Changed 14 years ago by
Attachment: | dropdowntimepicker.2.zip added |
---|
Fixes IE error and hiding issues
comment:7 Changed 14 years ago by
Keywords: | timepicker dropdowntimepicker added |
---|---|
Summary: | [patch] DropDownTimePicker widget → [cla] [patch] DropDownTimePicker widget |
comment:8 Changed 14 years ago by
Cc: | [email protected]… [email protected]… added |
---|
Lance,
Can you update these changes to be congruent with the current structure of the widgets? (no /html/ directory and templates/css are just Widgetname.html/css. The reason behind this is that Html based widgets now extend widget/HtmlWidget.js
-Karl ps. a *.diff/*.patch file would be a better way to submit it as well, as it can be reviewed directly via the trac website.
comment:9 Changed 14 years ago by
Resolution: | → invalid |
---|---|
Status: | assigned → closed |
Actually, after reviewing this current code closer, this isn't an update to our current TimePicker? like I understood it to be. This ticket is resolved as we already have a functioning TimePicker? and DropdownTimePicker?.
-Karl
Forgot to put contact details! Contact details are:
Lance Duivenbode dojo AT duivenbode DOT id DOT au