Opened 10 years ago

Closed 10 years ago

#10614 closed defect (fixed)

FlickrRestStore broken for all large images

Reported by: Shane O'Sullivan Owned by: Shane O'Sullivan
Priority: high Milestone: 1.4.1
Component: Dojox Version: 1.4.0
Keywords: Cc: Jared Jurkiewicz
Blocked By: Blocking:

Description

Changeset [21015] broke the FlickrRestStore?. It calculates the default "imageUrl" image to end in "_l.jpg", when it should just end with ".jpg".

It would be advisable to test this store against the dojox.image.Slideshow and Gallery widgets before committing changes, as they are a good test case that uses paging and different image sizes.

Attachments (2)

FlickrRestStore_largeImage.patch (3.7 KB) - added by Shane O'Sullivan 10 years ago.
Patch to fix this issue, plus some small style fixes
FlickrRestStore_largeImage2.patch (702 bytes) - added by Shane O'Sullivan 10 years ago.
Fix for this issue, with no style changes

Download all attachments as: .zip

Change History (7)

Changed 10 years ago by Shane O'Sullivan

Patch to fix this issue, plus some small style fixes

comment:1 Changed 10 years ago by Adam Peller

please avoid style changes on the 1.4 branch

Changed 10 years ago by Shane O'Sullivan

Fix for this issue, with no style changes

comment:2 Changed 10 years ago by Adam Peller

fix must go on the 1.4 branch also for 1.4.1. style changes are ok on trunk.

comment:3 Changed 10 years ago by Adam Peller

[21126] apparently applied this to trunk but not 1.4. Last chance for 1.4.1 - if this patch is working well.

comment:4 Changed 10 years ago by Shane O'Sullivan

(In [21186]) Refs #10614 Fixes the issue where large images cannot be retrieved from the FlickrRestStore?

comment:5 Changed 10 years ago by Shane O'Sullivan

Resolution: fixed
Status: newclosed

Checked in the fix for 1.4.1. Closing this ticket.

Note: See TracTickets for help on using tickets.