[patch] [cla] dijit.form.Select::attr('value', 'something', FALSE) fires onChange even when the priorityChange==FALSE

[s van gemmert]

dojo: version 1.4.0

when calling

dijit.form.Select::attr('value', 'something', FALSE)

with the "priorityChange" param explicitly set to FALSE, the onChange event should not be triggered This example shows that the Select widget does trigger the onChange in such a case. This seems to be caused by the _handleOnChange call in dijit.form.Select::_updateSelection. By setting the priorityChange to False there solves the problem. But it seems like the whole call to _handleOnChange can be removed there...

[s van gemmert]

code to reproduce

[Nathan Toone]

Unassigning my tickets.

[ben hockey]

i've just noticed this same problem in 1.5 beta and also had figured out the same fix - remove the call to _handleOnChange in _updateSelection. i've attached a patch for it and all the unit tests still pass with the change but i'm not familiar enough with this widget to be sure it won't break anything.

if someone else will take a look at it, they can either apply the patch or let me know to do it. hopefully if it doesn't make 1.5.0 it could make 1.5.1

[bill]

I talked to neonstalwart about this on IRC. The patch looks good, although I don't think it's critical enough to go into a point release. I'll mark it for 1.6 for now although I don't mind it going into 1.5 if it's put in before the RC which will theoretically happen on Monday.

[ben hockey]

(In [22542]) prevent onChange from firing when priorityChange is false and added a test for this. fixes #10594 !strict