Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#10579 closed defect (fixed)

dojox.layout.RadioGroup Issues

Reported by: cyface Owned by: dante
Priority: low Milestone: 1.6
Component: DojoX Layout Version: 1.4.0
Keywords: Cc:
Blocked By: Blocking:

Description

The tests for dojox.layout.RadioGroup? don't cover two scenarios, which when covered, point out a couple of issues.

1) The tests use images only. If you use text for the contents of the ContentPanes?, you'll note that the hidden panes aren't getting set to display:none, even though onShow, they are being set to display:"". Simply adding a set display:none to the onHide master method makes it work as expected.

2) All the tests show the buttons. If the buttons are being shown, the code adds position:absolute to the container. As a result, the slides work. If you don't show the buttons, no position:absolute, so the slides do not work. If you just move the set position:absolute into the main body of the init, and not as part of the button init, it works fine.

Cheers, and thanks for the great work on this!

Change History (3)

comment:1 Changed 9 years ago by dante

Milestone: tbd1.6
Status: newassigned

comment:2 Changed 9 years ago by dante

Resolution: fixed
Status: assignedclosed

(In [22515]) fixes #10579 - thanks for the report cyface. should cover everything addressed. added tests, updated to default to claro

comment:3 Changed 9 years ago by bill

Component: DojoX WidgetsDojoX Layout
Note: See TracTickets for help on using tickets.