Opened 11 years ago
Closed 11 years ago
#10571 closed enhancement (fixed)
dojo.fx chain/combine not extendable
Reported by: | Mike Wilcox | Owned by: | Mike Wilcox |
---|---|---|---|
Priority: | high | Milestone: | 1.6 |
Component: | fx | Version: | 1.4.0 |
Keywords: | Cc: | Eugene Lazutkin, dante | |
Blocked By: | Blocking: |
Description
I've developed code that easily reverses an animation. This same code also ads reverse functionality to chain and combine if they exist.
However, due to the private variables used, it can't be done. The attached patch would expose them both: dojo.fx._combine = _combine; dojo.fx._chain = _chain;
The alternative is to rewrite the code so that it doesn't use privates in the first place.
Attachments (1)
Change History (8)
Changed 11 years ago by
comment:1 Changed 11 years ago by
comment:2 Changed 11 years ago by
Owner: | changed from dante to Eugene Lazutkin |
---|---|
Status: | new → assigned |
comment:3 Changed 11 years ago by
comment:4 Changed 11 years ago by
Cc: | Eugene Lazutkin dante added |
---|---|
Owner: | changed from Eugene Lazutkin to Mike Wilcox |
Status: | assigned → new |
comment:5 Changed 11 years ago by
Milestone: | 1.5 → 1.6 |
---|
comment:7 Changed 11 years ago by
Resolution: | → fixed |
---|---|
Status: | new → closed |
IIRC, instead of using my extension of chain/combo which felt kludgey, I wrote a whole new animation type instead: http://docs.dojocampus.org/dojox/fx/Timeline
Note: See
TracTickets for help on using
tickets.
Ref ticket for reversing an animation: http://bugs.dojotoolkit.org/attachment/ticket/10572/