#10563 closed enhancement (fixed)
[patch][cla]dojox.editor.plugins.InsertEntity extend _PaletteMixin
Reported by: | youngho | Owned by: | bill |
---|---|---|---|
Priority: | high | Milestone: | 1.5 |
Component: | Editor | Version: | 1.4.0 |
Keywords: | editor insertEntity | Cc: | |
Blocked By: | Blocking: |
Description
I patched the InsertEntity? plugin with #10561 (dijit._PaletteMixin)
Attachments (2)
Change History (9)
Changed 11 years ago by
Attachment: | insertEntity.patch added |
---|
comment:1 Changed 11 years ago by
Milestone: | tbd → 1.5 |
---|---|
Owner: | set to bill |
Status: | new → assigned |
comment:2 Changed 11 years ago by
comment:3 Changed 11 years ago by
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
(In [21101]) Convert EntityPalette? to run on top of _PaletteMixin rather than cutting and pasting hundreds of lines of code.
Patch from Youngho Cho (thanks!), CLA on file. Some modifications from me too.
Fixes #10563 !strict.
comment:4 Changed 11 years ago by
Summary: | [patch][cla]dojox.editor.plugins.InsertEntity → [patch][cla]dojox.editor.plugins.InsertEntity extend _PaletteMixin |
---|
PS: I modified _PaletteMixin to use a <table> rather than absolutely positioned/sized <span> nodes, thus allowing this to work.
comment:5 Changed 11 years ago by
add missing _onCellMouseEnter method for preview works when onmouseover the cell and some height css adjust to remove cell height vibration when cell highlight.
Changed 11 years ago by
Attachment: | entityplugin.patch added |
---|
comment:6 Changed 11 years ago by
comment:7 Changed 11 years ago by
(In [22004]) Fixing to use more of the PaletteMixin? stuff (removes some code used for events). refs #10563
This will have to be reworked somewhat. Since each cell is a character rather than an icon, we can't assume a certain dimension (like 18x18). The old code that used a <table> seems better, although the focus and keyboard handling code can still be shared (inherited) from _PaletteMixin.