Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#10563 closed enhancement (fixed)

[patch][cla]dojox.editor.plugins.InsertEntity extend _PaletteMixin

Reported by: youngho Owned by: bill
Priority: high Milestone: 1.5
Component: Editor Version: 1.4.0
Keywords: editor insertEntity Cc:
Blocked By: Blocking:

Description

I patched the InsertEntity? plugin with #10561 (dijit._PaletteMixin)

Attachments (2)

insertEntity.patch​ (17.4 KB) - added by youngho 9 years ago.
entityplugin.patch​ (2.1 KB) - added by youngho 9 years ago.

Download all attachments as: .zip

Change History (9)

Changed 9 years ago by youngho

Attachment: insertEntity.patch​ added

comment:1 Changed 9 years ago by bill

Milestone: tbd → 1.5
Owner: set to bill
Status: new → assigned

comment:2 Changed 9 years ago by bill

This will have to be reworked somewhat. Since each cell is a character rather than an icon, we can't assume a certain dimension (like 18x18). The old code that used a <table> seems better, although the focus and keyboard handling code can still be shared (inherited) from _PaletteMixin.

comment:3 Changed 9 years ago by bill

Resolution: → fixed
Status: assigned → closed

(In [21101]) Convert EntityPalette? to run on top of _PaletteMixin rather than cutting and pasting hundreds of lines of code.

Patch from Youngho Cho (thanks!), CLA on file. Some modifications from me too.

Fixes #10563 !strict.

comment:4 Changed 9 years ago by bill

Summary: [patch][cla]dojox.editor.plugins.InsertEntity → [patch][cla]dojox.editor.plugins.InsertEntity extend _PaletteMixin

PS: I modified _PaletteMixin to use a <table> rather than absolutely positioned/sized <span> nodes, thus allowing this to work.

comment:5 Changed 9 years ago by youngho

add missing _onCellMouseEnter method for preview works when onmouseover the cell and some height css adjust to remove cell height vibration when cell highlight.

Changed 9 years ago by youngho

Attachment: entityplugin.patch​ added

comment:6 Changed 9 years ago by bill

(In [21109]) Fix preview on mouse over (since mouse over no longer causes a focus event), and fix jitter due to highlighting of hovered cell. Patch from Youngho Cho (CLA on file), thanks! Refs #10563 !strict.

comment:7 Changed 9 years ago by Jared Jurkiewicz

(In [22004]) Fixing to use more of the PaletteMixin? stuff (removes some code used for events). refs #10563

Note: See TracTickets for help on using tickets.