Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#10562 closed enhancement (fixed)

[patch][cla]dojox.editor.plugins.Smiley

Reported by: youngho Owned by: bill
Priority: high Milestone: 1.5
Component: Editor Version: 1.4.0
Keywords: editor smiley plugin Cc: Adam Peller
Blocked By: Blocking:

Description

I patched the Smliey plugin with #10561 (dijit._PaletteMixin)

Attachments (8)

smiley.patch​ (24.9 KB) - added by youngho 10 years ago.
module.js​ (389 bytes) - added by youngho 10 years ago.
runTests.html​ (301 bytes) - added by youngho 10 years ago.
Editor_Smiley.html​ (1.7 KB) - added by youngho 10 years ago.
Smiley.js​ (542 bytes) - added by youngho 10 years ago.
ko lang transtate
5x4.gif​ (4.8 KB) - added by youngho 10 years ago.
emotions folder image
smileyDisabled.gif​ (404 bytes) - added by youngho 10 years ago.
disabled button image
smileycss.patch​ (936 bytes) - added by youngho 10 years ago.
css patch for disabled button

Download all attachments as: .zip

Change History (13)

Changed 10 years ago by youngho

Attachment: smiley.patch​ added

Changed 10 years ago by youngho

Attachment: module.js​ added

Changed 10 years ago by youngho

Attachment: runTests.html​ added

Changed 10 years ago by youngho

Attachment: Editor_Smiley.html​ added

Changed 10 years ago by youngho

Attachment: Smiley.js​ added

ko lang transtate

Changed 10 years ago by youngho

Attachment: 5x4.gif​ added

emotions folder image

comment:1 Changed 10 years ago by Adam Peller

Cc: Adam Peller added

comment:2 Changed 10 years ago by bill

Milestone: tbd → 1.5
Owner: set to bill
Status: new → assigned

comment:3 Changed 10 years ago by bill

Resolution: → fixed
Status: assigned → closed

(In [21100]) Get Smiley plugin working, and also convert it to run on top of _PaletteMixin rather than cutting and pasting hundreds of lines of code.

Also added regression test (it's just a partial test now, it doesn't check using the dropdown or the post-filter functionality), and korean translation.

Patch from Youngho Cho (thanks!), CLA on file. Some modifications from me too.

Fixes #10562 !strict.

comment:4 Changed 10 years ago by youngho

attach missing smiley disabled button image and related css patch

Changed 10 years ago by youngho

Attachment: smileyDisabled.gif​ added

disabled button image

Changed 10 years ago by youngho

Attachment: smileycss.patch​ added

css patch for disabled button

comment:5 Changed 10 years ago by bill

(In [21106]) Icon for disabled smiley plugin, thanks youngho, refs #10562.

Note: See TracTickets for help on using tickets.