Opened 9 years ago

Closed 8 years ago

#10557 closed enhancement (wontfix)

add a few more plugins as ToggleButtons

Reported by: ben hockey Owned by:
Priority: high Milestone: tbd
Component: Editor Version: 1.4.0
Keywords: Cc:
Blocked By: Blocking:

Description

it would be nice to show the state of a few more plugins. currently we just show bold, italic, underline, subscript and superscript.

i have tried the following on ff3.5 and ie6 - insertOrderedList, insertUnorderedList, justifyCenter, justifyFull, justifyLeft and justifyRight. the only problem i see on these 2 browsers is that ie6 does not show justifyLeft when it is applied. this is not a big deal (at least for ltr) and adding these would give more feedback to the users.

i haven't got a patch but the change is simple if you want to try for yourself in Editor.js:

		case "bold": case "italic": case "underline": case "strikethrough":
		case "subscript": case "superscript": case "insertOrderedList":
		case "insertUnorderedList": case "justifyCenter":
		case "justifyFull": case "justifyLeft": case "justifyRight":
			p = new _p({ buttonClass: dijit.form.ToggleButton, command: name });
			break;

Change History (1)

comment:1 Changed 8 years ago by Jared Jurkiewicz

Resolution: wontfix
Status: newclosed

The problem with doing that is untoggling the button doesn't remove the state, but the button shows the state as 'unset'. Toggle buttons don't really work here as those commands don't work like the bold/italic ones do. We would need a different way to denote applied here.

Closing this bug as won't fix. Sorry. The suggested changes introduce worse problems.

Note: See TracTickets for help on using tickets.