Opened 11 years ago

Closed 11 years ago

Last modified 9 years ago

#10525 closed defect (fixed)

Dialog: exception on page unload when Dialog is shown (IE)

Reported by: bill Owned by: bill
Priority: high Milestone: 1.4.2
Component: Dijit Version: 1.4.0
Keywords: Cc:
Blocked By: Blocking:

Description

Seeing errors on the attached scripts (against dojo 1.3 and dojo 1.4 google CDN, plus against trunk) when refreshing the page or shutting down the browser.

Steps to reproduce:

  1. click menu / sub menu / item 3 to bring up dialog
  2. close dialog
  3. repeat step 1
  4. close browser or click refresh

At this point, on dojo 1.3 I get an exception dialog:

this.domNode.style is not defined

On dojo 1.4 I get:

this.bgIframe is not defined

Presumably the dialog only pops up if the browser has the setting to display alerts on all exceptions.

Reproduced on IE6.

Attachments (3)

exampleMenu.html​ (3.1 KB) - added by bill 11 years ago.
against trunk
exampleMenu13.html​ (3.2 KB) - added by bill 11 years ago.
against 1.3 google cdn
exampleMenu14.html​ (2.8 KB) - added by bill 11 years ago.
against 1.4 google cdn

Download all attachments as: .zip

Change History (7)

Changed 11 years ago by bill

Attachment: exampleMenu.html​ added

against trunk

Changed 11 years ago by bill

Attachment: exampleMenu13.html​ added

against 1.3 google cdn

Changed 11 years ago by bill

Attachment: exampleMenu14.html​ added

against 1.4 google cdn

comment:1 Changed 11 years ago by bill

Resolution: → fixed
Status: new → closed

(In [21059]) During page unload while Dialog is shown, the underlay may be destroyed before the Dialog itself. In that case, the Dialog shouldn't try to hide the underlay (as it causes an exception). Fixes #10525.

comment:2 Changed 11 years ago by bill

(In [21406]) Backport [21059] to 1.4 branch; fixes exception on page unload if underlay gets destroyed before an open Dialog. Refs #10525 !strict.

comment:3 Changed 11 years ago by bill

Milestone: 1.5 → 1.4.2

comment:4 Changed 9 years ago by bill

In [28334]:

Improve guard code for when underlay may already be destroyed, refs #10525 !strict.

Note: See TracTickets for help on using tickets.