#10510 closed defect (fixed)
[patch] [cla] Editor bad restoreSelection on IE8 when caret is at the end of a line
Reported by: | jfcunat | Owned by: | Jared Jurkiewicz |
---|---|---|---|
Priority: | high | Milestone: | 1.5 |
Component: | Editor | Version: | 1.4.0 |
Keywords: | editor selection | Cc: | |
Blocked By: | Blocking: |
Description
1)Use test_Editor.html 2) you move the caret at the end of a line inside the second visible editor 3) add bullet via the button plugin --> the bullet is added to the next line. the same happens to insert content, images ...
It seems to be related to a bug on Ie with selection (http://stackoverflow.com/questions/130186/ie-textrange-select-method-not-working-properly)
No idea to correct that. The only way I think about is to disable restoreSelection when selection isCollapsed = true in Editor.js But doing this will not restore caret position when going back to the editor if no selection was done before
Attachments (2)
Change History (11)
Changed 13 years ago by
Attachment: | patch_EditorSelection.txt added |
---|
comment:1 Changed 13 years ago by
comment:2 Changed 13 years ago by
Owner: | set to Jared Jurkiewicz |
---|---|
Summary: | Editor bad restoreSelection on IE8 when caret is at the end of a line → [patch] [cla] Editor bad restoreSelection on IE8 when caret is at the end of a line |
comment:3 Changed 13 years ago by
That may not work. There are plugins that need the caret position restored to function properly. Examples are InsertEntity?, CreateImage?, CreateLink?, and so on. Would need to verify they focus the editor explictly so selections restore.
Changed 13 years ago by
Attachment: | Editor.js.ie8.patch added |
---|
Potential alternative patch for selection (caret) restore
comment:4 Changed 13 years ago by
I attached a possible 'alternative' patch to the behavior. But I am not certain I tested it correctly. Can you try it in your environment and see if it works?
comment:5 Changed 12 years ago by
Followup.
Originator: Please try the supplied patch and tell me if it resolves the issue you're seeing. Your 'fix' will not work.
comment:7 Changed 12 years ago by
Milestone: | 1.5 → future |
---|
Setting milestone to future, as the originator of the defect has thus far been non-responsive and I cannot get verification of the alternative (better), patch
comment:8 Changed 12 years ago by
Resolution: | → fixed |
---|---|
Status: | new → closed |
This may be fixed by #10685, so closing. Please reopen if still an issue.
comment:9 Changed 12 years ago by
Milestone: | future → 1.5 |
---|
Proposed patch : disable restoreSelection when using execCommand RichText?. By this way, we keep the previous behaviour to keep selection when focusing editor but not when we use a plugin