[patch][ccla][regression][minor]: Fontchoice plugin doesn't allow you to set the plugin state to the same value after move

[Jared Jurkiewicz]

This is a problem that occurs when the following sequence happens:

Given the following html:

<p>Paragraph 1</p>
<p>Paragraph 2</p>

1.) You click in Paragraph 2. Format dropdown updates to 'Paragraph' (Correct)
2.) Change it to Heading
3.) Click in to Paragraph 1. Format dropdown updates back to 'Paragraph' (Correct)
4.) Try to change it to heading. It will not change.

This occurs because the updateState function makes use of the 'priorityChange' parameter of attr for FilteringSelect?. This was needed because FilteringSelect?'s onChange operates asynchronously. When update state changes the dropdown, you do not want an 'onChange' to happen, because onChange is attached to work as a user change vent and when it happens, the formatblock operation is called. For state update,s you don't want to actually do an operation. Since FilteringSelect? is async, you can't just 'ignore' an event easily (since you don't know precisely when the state is going to fire). So that priorityChange param is very useful here.

The problem comes in, in that priorityChange false doesn't reset the last internal state value. So even though in step 3-4 it updatestate changes to 'Paragrah', internally it still things the state is 'Heading'. So when we try to set to heading, it thinks that is the current state ... and ignores the event, no onchange fies, and no formatblock is called.

Douglas Hays said this is expected behavior of using priorityChange, unfortunately. He did give me a workaround for the issue, though, and I'll provide a patch plus unit test case for it shortly.

Targetting for 1.4.1, as this is a really annoying behavior and is a regression from 1.3.2. (That all said, the plugin still works far better than it didn in 1.3.2, I fixed tons of cross-browser behavioral issues).

[Jared Jurkiewicz]

Small patch that fixes the issue

[Jared Jurkiewicz]

Updated UT, fixed some tab/spaces issues.

[Jared Jurkiewicz]

(In [20988]) Checking in fix for FontChoice? + UT. refs #10466

[Jared Jurkiewicz]

(In [21004]) Committing fix + ut update for 1.4.1. fixes #10466