Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#10457 closed defect (fixed)

[patch][ccla] Incorrect handling commented script tags in dojox.html._base

Reported by: bogool Owned by: Jared Jurkiewicz
Priority: high Milestone: 1.4.1
Component: Dojox Version: 1.4.0b
Keywords: Cc: mumme, bill
Blocked By: Blocking:

Description

The regexp in snarfScripts function incorrectly handles comments like this:

<!-- script> some code here </script -->

Example attached.

Attachments (3)

ContentPaneBug.html​ (522 bytes) - added by bogool 11 years ago.
Example code
ContentPaneBug_cnt.html​ (258 bytes) - added by bogool 11 years ago.
Datafile for example
script.patch​ (415 bytes) - added by Jared Jurkiewicz 11 years ago.
Potential patch

Download all attachments as: .zip

Change History (9)

Changed 11 years ago by bogool

Attachment: ContentPaneBug.html​ added

Example code

Changed 11 years ago by bogool

Attachment: ContentPaneBug_cnt.html​ added

Datafile for example

comment:1 Changed 11 years ago by Adam Peller

Cc: mumme bill added
Owner: changed from Adam Peller to Sam Foster

comment:2 Changed 11 years ago by Jared Jurkiewicz

Milestone: tbd → 1.4.1
Owner: changed from Sam Foster to Jared Jurkiewicz

Assigning to me, I know why it happens and have a potential fix. Targetting for 1.4.1

Changed 11 years ago by Jared Jurkiewicz

Attachment: script.patch​ added

Potential patch

comment:3 Changed 11 years ago by Jared Jurkiewicz

Summary: Incorrect handling commented script tags in dojox.html._base → [patch][ccla] Incorrect handling commented script tags in dojox.html._base

comment:4 Changed 11 years ago by Jared Jurkiewicz

Status: new → assigned

comment:5 Changed 11 years ago by Jared Jurkiewicz

Resolution: → fixed
Status: assigned → closed

(In [21006]) Fixing script collection issue. Regression from 1.3. \!strict fixes #10457

comment:6 Changed 11 years ago by Jared Jurkiewicz

Also fixed in trunk commit: [20984]

Note: See TracTickets for help on using tickets.