Opened 11 years ago
Closed 11 years ago
#10453 closed defect (fixed)
Dialog: uninitialize may cause problem on nested dialog (race condition with fadeOut)
Reported by: | Manuel Irrschik | Owned by: | bill |
---|---|---|---|
Priority: | high | Milestone: | 1.6 |
Component: | Dijit | Version: | 1.4.0b |
Keywords: | dijit.Dialog nested underlay | Cc: | |
Blocked By: | Blocking: |
Description
i've noticed a (minor) problem with nested Dialogs:
if the upper most dialog's unitialize method is called before the fadeOut is complete (e.g. dialog is destroyed or so) the underlay is hidden directly instead of running through the new nested-dialog code.
(see Line 252 of Dialog.js http://bugs.dojotoolkit.org/browser/dijit/trunk/Dialog.js?rev=#L252)
fix should be to move the nested-dialog code to a separate function and call it from both places (i appended a possible fix which i am using currently)
Attachments (1)
Change History (7)
Changed 11 years ago by
Attachment: | Dialog.patch added |
---|
comment:1 follow-up: 2 Changed 11 years ago by
Milestone: | 1.4 → 1.5 |
---|---|
Summary: | dijit.Dialog: uninitialize may cause problem on nested dialog (race condition with fadeOut) → Dialog: uninitialize may cause problem on nested dialog (race condition with fadeOut) |
comment:2 Changed 11 years ago by
Replying to bill:
Can you sign a CLA (http://www.dojofoundation.org/cla) so that we can look at your patch?
sry, i wasn't aware of that, just signed it and sent it by mail
comment:4 Changed 11 years ago by
Milestone: | 1.5 → 1.6 |
---|
comment:5 Changed 11 years ago by
Owner: | set to bill |
---|---|
Status: | new → assigned |
This was fixed in [22662], although I did just notice that the destroy() (aka uninitialize()) code should be cancelling any running animations, so I'll check that in.
comment:6 Changed 11 years ago by
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
Oh actually, it already does that. So this is fixed already. (But please double check on your test case.)
OK, thanks, I'll take a look for 1.5. Can you sign a CLA (http://www.dojofoundation.org/cla) so that we can look at your patch?
There are some other tickets open about Dialog related to race conditions too.