Dialog: uninitialize may cause problem on nested dialog (race condition with fadeOut)

[Manuel Irrschik]

i've noticed a (minor) problem with nested Dialogs:

if the upper most dialog's unitialize method is called before the fadeOut is complete (e.g. dialog is destroyed or so) the underlay is hidden directly instead of running through the new nested-dialog code.

(see Line 252 of Dialog.js ​http://bugs.dojotoolkit.org/browser/dijit/trunk/Dialog.js?rev=#L252)

fix should be to move the nested-dialog code to a separate function and call it from both places (i appended a possible fix which i am using currently)

[bill]

OK, thanks, I'll take a look for 1.5. Can you sign a CLA (​http://www.dojofoundation.org/cla) so that we can look at your patch?

There are some other tickets open about Dialog related to race conditions too.

[Manuel Irrschik]

Replying to bill:

Can you sign a CLA (​http://www.dojofoundation.org/cla) so that we can look at your patch?

sry, i wasn't aware of that, just signed it and sent it by mail

[bill]

Thanks! (And future patches always appreciated too.)

[bill]

This was fixed in [22662], although I did just notice that the destroy() (aka uninitialize()) code should be cancelling any running animations, so I'll check that in.

[bill]

Oh actually, it already does that. So this is fixed already. (But please double check on your test case.)