#10444 closed enhancement (fixed)
[patch][cla]FlickrRestStore and Original Url
| Reported by: | emperorcezar | Owned by: | Jared Jurkiewicz |
|---|---|---|---|
| Priority: | high | Milestone: | 1.5 |
| Component: | DojoX Data | Version: | 1.4.0b |
| Keywords: | Cc: | ||
| Blocked By: | Blocking: |
Description
The FlickrRestStore? doesn't support obtaining the original url for image. It also build the urls for the other sizes when the api will simply return the correct urls with the request.
I created a patch and have it attached to this bug upon instructions from the #dojo irc channel.
Attachments (1)
Change History (14)
Changed 9 years ago by
| Attachment: | FlickrRestStore.js.patch added |
|---|
comment:1 Changed 9 years ago by
| Component: | General → DojoX Data |
|---|---|
| Owner: | changed from anonymous to Jared Jurkiewicz |
| Summary: | FlickrRestStore and Original Url → [patch][no cla]FlickrRestStore and Original Url |
comment:2 Changed 9 years ago by
| Milestone: | tbd → 1.5 |
|---|
comment:5 Changed 9 years ago by
emperorcezar,
What's your actual name? I'm trying to validate your CLA was recieved.
comment:6 Changed 9 years ago by
| Summary: | [patch][no cla]FlickrRestStore and Original Url → [patch][cla]FlickrRestStore and Original Url |
|---|
CLA verified.
comment:7 Changed 9 years ago by
| Status: | new → assigned |
|---|
comment:8 Changed 9 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
(In [20987]) Committing in FlickrRestStore? enhancement. fixes #10444
comment:9 Changed 9 years ago by
| Resolution: | fixed |
|---|---|
| Status: | closed → reopened |
There is a good reason that the store calculates the URLs for the images, and it's the same reason that Flickr has a simple pattern for it - it saves the number of bytes over the wire. Adding 5 new URLs to every image could easily treble the size of the downloaded data. I don't think that's worth it just to save a few lines of JavaScript? in the store.
Jared, would you be in favour of backing out that part of the patch? I have no problem with adding in a method to get the original url, but that can be calculated too as far as I'm aware. We do not have to download it every time.
comment:11 Changed 9 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | reopened → closed |
comment:12 Changed 9 years ago by
shane is right, bu including the urls, it substantially increases the amount of data flickr has to send on the wire. Since it can be easily calculated fro the basic data, performance is improved by reducing wire size.
Patch adding original url to the FlickrRestStore?