Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#10444 closed enhancement (fixed)

[patch][cla]FlickrRestStore and Original Url

Reported by: emperorcezar Owned by: Jared Jurkiewicz
Priority: high Milestone: 1.5
Component: DojoX Data Version: 1.4.0b
Keywords: Cc:
Blocked By: Blocking:

Description

The FlickrRestStore? doesn't support obtaining the original url for image. It also build the urls for the other sizes when the api will simply return the correct urls with the request.

I created a patch and have it attached to this bug upon instructions from the #dojo irc channel.

Attachments (1)

FlickrRestStore.js.patch (10.7 KB) - added by emperorcezar 10 years ago.
Patch adding original url to the FlickrRestStore?

Download all attachments as: .zip

Change History (14)

Changed 10 years ago by emperorcezar

Attachment: FlickrRestStore.js.patch added

Patch adding original url to the FlickrRestStore?

comment:1 Changed 10 years ago by Adam Peller

Component: GeneralDojoX Data
Owner: changed from anonymous to Jared Jurkiewicz
Summary: FlickrRestStore and Original Url[patch][no cla]FlickrRestStore and Original Url

comment:2 Changed 10 years ago by Jared Jurkiewicz

Milestone: tbd1.5

comment:3 Changed 10 years ago by Jared Jurkiewicz

Targetting 1.5, as 1.4 is locked down.

comment:4 Changed 10 years ago by emperorcezar

The cla was faxed yesterday before I submitted the ticket.

comment:5 Changed 10 years ago by Jared Jurkiewicz

emperorcezar,

What's your actual name? I'm trying to validate your CLA was recieved.

comment:6 Changed 10 years ago by Jared Jurkiewicz

Summary: [patch][no cla]FlickrRestStore and Original Url[patch][cla]FlickrRestStore and Original Url

CLA verified.

comment:7 Changed 10 years ago by Jared Jurkiewicz

Status: newassigned

comment:8 Changed 10 years ago by Jared Jurkiewicz

Resolution: fixed
Status: assignedclosed

(In [20987]) Committing in FlickrRestStore? enhancement. fixes #10444

comment:9 Changed 10 years ago by Shane O'Sullivan

Resolution: fixed
Status: closedreopened

There is a good reason that the store calculates the URLs for the images, and it's the same reason that Flickr has a simple pattern for it - it saves the number of bytes over the wire. Adding 5 new URLs to every image could easily treble the size of the downloaded data. I don't think that's worth it just to save a few lines of JavaScript? in the store.

Jared, would you be in favour of backing out that part of the patch? I have no problem with adding in a method to get the original url, but that can be calculated too as far as I'm aware. We do not have to download it every time.

comment:10 Changed 10 years ago by Jared Jurkiewicz

Reverted to calculating in [21015]

comment:11 Changed 10 years ago by Jared Jurkiewicz

Resolution: fixed
Status: reopenedclosed

comment:12 Changed 10 years ago by Jared Jurkiewicz

shane is right, bu including the urls, it substantially increases the amount of data flickr has to send on the wire. Since it can be easily calculated fro the basic data, performance is improved by reducing wire size.

comment:13 Changed 10 years ago by Jared Jurkiewicz

(In [21065]) Fixing minor tab/space issues and eol stuff. refs #10444

Note: See TracTickets for help on using tickets.