Opened 10 years ago

Closed 10 years ago

Last modified 8 years ago

#10443 closed enhancement (fixed)

Provide stack traces on doh errors

Reported by: Adam Peller Owned by: Adam Peller
Priority: high Milestone: 1.5
Component: TestFramework Version: 1.4.0b
Keywords: Cc: alex, dante, James Burke, jcerruti@…
Blocked By: Blocking:

Description (last modified by Adam Peller)

From Julian Cerruti (IBM):

This patch modifies doh to send Error objects generated inside unit tests to console.error instead of console.debug, if we're running inside Firefox and that method is available.

This adds the stack trace together with the Error object in the Firebug console. Also, the objects in the Firebug console are actionable and can be inspected.

If using dojo, this works specifically well if matched with Firebug 1.5 (b5 or later), which properly jumps to the proper source code file and line when clicking on each method in the stack trace.

Attachments (1)

doh-stack-trace.diff (2.1 KB) - added by Adam Peller 10 years ago.
Patch from Julian Cerruti (IBM)

Download all attachments as: .zip

Change History (5)

comment:1 Changed 10 years ago by Adam Peller

Description: modified (diff)

Changed 10 years ago by Adam Peller

Attachment: doh-stack-trace.diff added

Patch from Julian Cerruti (IBM)

comment:2 Changed 10 years ago by Adam Peller

Resolution: fixed
Status: newclosed

(In [21228]) Patch from Julian Cerruti (IBM) to use console error to expose Error objects and stack traces. Fixes #10443 Thanks, Julian !strict

comment:3 Changed 8 years ago by David Rees

(I'm looking for a little more context on this patch. I can see how the error object is passed to Firebug and it does display it, but I am not seeing the ability to "jumps to the proper source code file and line when clicking on each method in the stack trace." as described by Julian. Instead I am seeing everything being associated with bootstrap.js (see http://twitpic.com/3v6wcg/full).

I have tried to work around this by using debugAtAllCosts, but I can't seem to get it to work. It seems like Julian has though and I am wondering if he could give us some pointers.

Could you possibly forward this to Julian?

Thanks, dave

PS, I posted on this in dojo mailing list as well a few days ago - http://bit.ly/dVBHC2.

comment:4 Changed 8 years ago by Adam Peller

Cc: jcerruti@… added

the bootstrap.js messages are not associated with the stack trace. It looks like that's the firebug console reporting the log messages themselves.

Note: See TracTickets for help on using tickets.