Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#10441 closed defect (fixed)

[patch][cla] ServiceStore does not pass fetch request object to onError callback

Reported by: avoidscorn Owned by: Kris Zyp
Priority: high Milestone: 1.4
Component: DojoX Data Version: 1.4.0b
Keywords: Cc:
Blocked By: Blocking:

Description

The dojo.data.api.Read documentation for the fetch method says that the onError callback will be passed two arguments: an Error object and the Request object. However, ServiceStore only passes the Error object to the onError callback.

The DataGrid widget expects a valid Request object in its onError callback and will throw a TypeError if the Request argument is undefined. The exception is swallowed by the deferred, but the grid is left in an invalid state (it will refuse to refresh itself from that point on).

The attached patch resolves the issue for me.

Attachments (1)

patch.txt (552 bytes) - added by avoidscorn 10 years ago.

Download all attachments as: .zip

Change History (4)

Changed 10 years ago by avoidscorn

Attachment: patch.txt added

comment:1 Changed 10 years ago by Jared Jurkiewicz

Owner: changed from Jared Jurkiewicz to Kris Zyp

comment:2 Changed 10 years ago by Kris Zyp

Resolution: fixed
Status: newclosed

(In [20937]) Adds request to the onError callback, fixes #10441

comment:3 Changed 10 years ago by Kris Zyp

Milestone: tbd1.4
Note: See TracTickets for help on using tickets.