Opened 10 years ago

Closed 10 years ago

Last modified 9 years ago

#10436 closed defect (fixed)

Date/TimeTextBox partialre messed up

Reported by: Douglas Hays Owned by: Douglas Hays
Priority: high Milestone: 1.5
Component: Dijit - Form Version: 1.4.0b
Keywords: Cc: bill
Blocked By: Blocking:

Description

Run test_TimeTextBox.html and focus the 2nd widget.
Enter the characters 12:
This is a valid subset yet the invalid input shows. The problem is that the parent postMixInProperties is run before _DateTExtBox has added the appropriate selector to the constraints.
I would like to add this to 1.4 if possible since it involves just moving the this.inherited line from the top to the bottom of postMixInProperties. This problem breaks all partial validation for date and time textboxes.

Attachments (1)

10436.patch (2.6 KB) - added by Douglas Hays 10 years ago.
moves this.inherited in _DateTimeTextBox:postMixInProperties after constraints tweaking so that partialre is initialized properly, and add automated test

Download all attachments as: .zip

Change History (7)

Changed 10 years ago by Douglas Hays

Attachment: 10436.patch added

moves this.inherited in _DateTimeTextBox:postMixInProperties after constraints tweaking so that partialre is initialized properly, and add automated test

comment:1 Changed 10 years ago by Douglas Hays

bill, do you want this fixed in 1.4?

comment:2 Changed 10 years ago by bill

Milestone: tbd1.5

Let's do this in 1.5, just to be on the safe side. And also we should have an automated test for this so that future code refactorings don't break anything.

comment:3 Changed 10 years ago by Douglas Hays

Resolution: fixed
Status: newclosed

(In [20978]) Fixes #10436 !strict. Change _DateTimeTextBox::postMixInProperties to call the superclass AFTER tweaking constraints so that the regexp is correctly generated based on the changed constraints. Add automated test.

comment:4 Changed 10 years ago by bill

(In [21388]) Get unit test working on IE and FF, refs #10436.

comment:5 Changed 10 years ago by bill

(In [21389]) Basic keyboard test for drop down, refs #10436.

comment:6 Changed 9 years ago by bill

Component: DijitDijit - Form
Note: See TracTickets for help on using tickets.