Opened 10 years ago

Closed 10 years ago

Last modified 8 years ago

#10435 closed defect (fixed)

Spinner, ComboBox: remove JS sizing and fix rendering glitches

Reported by: Douglas Hays Owned by: Douglas Hays
Priority: high Milestone: 1.5
Component: Dijit - Form Version: 1.4.0b
Keywords: Cc: bill
Blocked By: Blocking:

Description (last modified by bill)

Spinner in IE7 has issues with page zoom. And ComboBox, Spinner, etc. have various other issues with up/down arrow sizing and validation icon sizing in quirks mode, or when the font-size is different than 100%, etc.

Originally this ticket was to fix those problems by using a <table>. However, that ran into problems on Chrome with the height of the <td> nodes for the up and down arrows: when the font-size is 200% (second example in test_Spinner.html), the up arrow cell is too short (and the down arrow cell is too tall).

Attachments (1)

tableSpinner2.patch (5.3 KB) - added by bill 10 years ago.
patch to use table for spinner (but has problems on webkit when line-height or padding specified on input

Download all attachments as: .zip

Change History (6)

comment:1 Changed 10 years ago by Douglas Hays

Type: defecttask

comment:2 Changed 10 years ago by bill

Description: modified (diff)
Summary: Spinner: investigate changing template to a TABLESpinner, ComboBox: remove JS sizing and fix rendering glitches
Type: taskdefect

comment:3 Changed 10 years ago by Douglas Hays

Resolution: fixed
Status: newclosed

(In [21560]) Fixes #10435, #10840 !strict. Tweak form/*TextBox? templates and CSS (including all dijit themes) so that they consistently render to the same height and width. Could not use a TABLE since WebKit? doesn't seem to support height:50% on a TD. Used an inner DIV with zoom:50% in IE to achieve the same height:50% effect. Added TextBox_sizes.html testcase to verify correct TextBox? subclass rendering. Added tests in dijit/form/module.js to test on all themes + RTL mode + quirks mode.

comment:4 Changed 10 years ago by Douglas Hays

(In [21561]) References #10435, #10840. Backout development test revision.

Changed 10 years ago by bill

Attachment: tableSpinner2.patch added

patch to use table for spinner (but has problems on webkit when line-height or padding specified on input

comment:5 Changed 8 years ago by bill

Component: DijitDijit - Form
Note: See TracTickets for help on using tickets.