Opened 9 years ago

Closed 9 years ago

#10433 closed defect (fixed)

[patch][ccla] RTL/FF3: Call to dojox.html.metrics.getTextBox() results in Horizontal Scroll Bar appearing

Reported by: Jared Jurkiewicz Owned by: Jared Jurkiewicz
Priority: high Milestone: 1.4.1
Component: Dojox Version: 1.3.2
Keywords: getTextBox, dojox.html.metrics Cc: bidi
Blocked By: Blocking:

Description

Reported by my co-worker:

The Dojo call returns the text box size by rendering the content 10000px off to the left side of the screen. In LTR, this is rendered in negative coordinate space, and as such is in non-displayable space. However in RTL with the coordinate system reversed, this is now considered a positive shift and is still visible space, and as a result the scroll bars appear, and you can scroll to the rendered DOM object. The fix is to either render it to the Right for RTL, or renter it 10000 beyond the top in both cases.

Testcase coming + patch

Assigning to Eugene since this code came from GFX and want his take on it

Attachments (2)

test_Metrics.html (1022 bytes) - added by Jared Jurkiewicz 9 years ago.
Testcase in RTL mode demonstrating horizontal scroller.
metrics.patch (453 bytes) - added by Jared Jurkiewicz 9 years ago.
Patch that fixes it by miving top out of view, not left.

Download all attachments as: .zip

Change History (9)

Changed 9 years ago by Jared Jurkiewicz

Attachment: test_Metrics.html added

Testcase in RTL mode demonstrating horizontal scroller.

Changed 9 years ago by Jared Jurkiewicz

Attachment: metrics.patch added

Patch that fixes it by miving top out of view, not left.

comment:1 Changed 9 years ago by Adam Peller

Owner: changed from uhop to Eugene Lazutkin

comment:2 Changed 9 years ago by Adam Peller

Cc: bidi added
Milestone: tbd1.4
Summary: RTL/FF3: Call to dojox.html.metrics.getTextBox() results in Horizontal Scroll Bar appearing[patch][ccla] RTL/FF3: Call to dojox.html.metrics.getTextBox() results in Horizontal Scroll Bar appearing

comment:3 Changed 9 years ago by Jared Jurkiewicz

Milestone: 1.41.4.1

comment:4 Changed 9 years ago by Jared Jurkiewicz

Owner: changed from Eugene Lazutkin to Jared Jurkiewicz

comment:5 Changed 9 years ago by Jared Jurkiewicz

Status: newassigned

comment:6 Changed 9 years ago by Jared Jurkiewicz

(In [20985]) Minor fix for html metrics getTextBox. refs #10433

comment:7 Changed 9 years ago by Jared Jurkiewicz

Resolution: fixed
Status: assignedclosed

(In [21005]) Fixing minor html metrics issue for RTL. fixes #10433

Note: See TracTickets for help on using tickets.