Opened 10 years ago

Closed 10 years ago

#10425 closed task (fixed)

testCommon.js problems when theme specified

Reported by: bill Owned by: bill
Priority: high Milestone: 1.5
Component: Dijit Version: 1.4.0b
Keywords: Cc:
Blocked By: Blocking:

Description

testCommon.js doesn't work so well when a theme is specified (different than the default tundra).

The dojo.addOnLoad() calls in the test file execute before the parser runs, and naturally fail. See test_ProgressBar.html for an example.

I'm attaching a patch to fix this, although it might be better to reduce the amount of magic and just use a specially defined function like testAddOnLoad() in all the test files, rather than dojo.addOnLoad().

Attachments (1)

testCommon.patch (2.2 KB) - added by bill 10 years ago.
patch against _testCommon.js

Download all attachments as: .zip

Change History (2)

Changed 10 years ago by bill

Attachment: testCommon.patch added

patch against _testCommon.js

comment:1 Changed 10 years ago by bill

Resolution: fixed
Status: newclosed

(In [20979]) Delay addOnLoad() execution until after parse happens, where parse itself is delayed waiting for the specified theme to load. Fixes #10425.

Note: See TracTickets for help on using tickets.