Opened 9 years ago

Closed 9 years ago

#10420 closed defect (fixed)

[patch][ccla] Editor image selection problem

Reported by: youngho Owned by: Jared Jurkiewicz
Priority: high Milestone: 1.5
Component: Editor Version: 1.4.0b
Keywords: editor image select Cc:
Blocked By: Blocking:

Description

I think dijit.Editor has a problem to select an image within editArea except FF. I attached the test file and robot test to show the problem. the robot test pass only FF.

Shortly if we click the mouse on the image, it doesn't run onClick method properly except FF.

I think it is not a feature but a editor bug.

Attachments (3)

test_Editor_ImageSelection.html (3.5 KB) - added by youngho 9 years ago.
Editor_ImageSelection.html (7.0 KB) - added by youngho 9 years ago.
ie_imgselect.patch (3.0 KB) - added by Jared Jurkiewicz 9 years ago.
Fix for image selection issue + UT.

Download all attachments as: .zip

Change History (8)

comment:1 Changed 9 years ago by youngho

Jared guide me that image selection can be helped by LinkDialog? plugin. And I realized that it is equivalent issue with single or double click selection.

I update the test code, and the test result shows that

FF3 IE8 Chrome Safari(Window)

without LinkDialog? plugin
SingleClick? O X X X
DoubleClick? O O X X

with LinkDialog? plugin
SingleClick? O X O O
DoubleClick? O O O O

With LinkDialog? Plugin, still there is a issue with IE8 single click selection trouble.
But I am not willing to keep this issue is a bug definitely.

But I hope IE has same behavior with other browers also.

Changed 9 years ago by youngho

Changed 9 years ago by youngho

Attachment: Editor_ImageSelection.html added

comment:2 Changed 9 years ago by bill

Milestone: tbd1.5

Marking for 1.5 for now.

comment:3 Changed 9 years ago by Jared Jurkiewicz

Owner: set to Jared Jurkiewicz
Status: newassigned

IE ignores the first click. I need to listen for onmousedown, not onclick, to get it working right in IE. Working on patch + UT.

Changed 9 years ago by Jared Jurkiewicz

Attachment: ie_imgselect.patch added

Fix for image selection issue + UT.

comment:4 Changed 9 years ago by Jared Jurkiewicz

Summary: Editor image selection problem[patch][ccla] Editor image selection problem

comment:5 Changed 9 years ago by Jared Jurkiewicz

Resolution: fixed
Status: assignedclosed

Fixed in [20986]

Note: See TracTickets for help on using tickets.