Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#10406 closed enhancement (fixed)

[patch] [cla] Add "required" validation to CheckedMultiSelect

Reported by: Nicholas VanderPyle Owned by: dante
Priority: low Milestone: 1.6
Component: DojoX Form Version: 1.4.0b
Keywords: Cc:
Blocked By: Blocking:

Description

It would be nice if CheckedMultiSelect? had an option to require that at least one item be selected and tie into Dojo's built-in validation.

I've attached a patch that supports this on my local build.

The patch also adds a callback (OnAfterAddOptionItem?) when an item is added to the list.

Attachments (1)

patch.txt (3.7 KB) - added by Nicholas VanderPyle 9 years ago.

Download all attachments as: .zip

Change History (6)

Changed 9 years ago by Nicholas VanderPyle

Attachment: patch.txt added

comment:1 Changed 9 years ago by bill

Summary: Add "required" validation to CheckedMultiSelect[patch] [no cla] Add "required" validation to CheckedMultiSelect

Hi Nicholas,

Actually can you file a CLA? We can't look at patches without them.

comment:2 Changed 9 years ago by Nicholas VanderPyle

Hi Bill, I should have a CLA on file.

I'm listed here: http://www.dojotoolkit.org/dojo-contributors as: VanderPlye?, Nicholas

It should be "VanderPyle?". Who should I email to get that corrected?

Also, to prevent future confusion, how do I specify on my Trac login that I have a CLA?

comment:3 Changed 9 years ago by bill

Summary: [patch] [no cla] Add "required" validation to CheckedMultiSelect[patch] [cla] Add "required" validation to CheckedMultiSelect

Ah great.

I didn't notice because of the typo. I think you can mail cla@… to get it fixed.

About the bugdb login: I don't know any way to mark users who have a CLA but if you write [patch] [cla] in the ticket summary (ie, the bug title) then we'll know.

comment:4 Changed 9 years ago by dante

Resolution: fixed
Status: newclosed

(In [22514]) fixes #10406 - adds validation support to multicheckbox, defaults to false. cleans up use of attr() throughout test and module, all tests pass. Also makes claro default theme and uses _testCommon

comment:5 Changed 9 years ago by bill

Milestone: tbd1.6
Note: See TracTickets for help on using tickets.