Opened 13 years ago
Closed 13 years ago
#10360 closed defect (fixed)
[regression] Soria Theme - Setting doLayout="false" in dijit.layout.TabContainer does not work for Soria theme.
Reported by: | Richard Palacios | Owned by: | bill |
---|---|---|---|
Priority: | high | Milestone: | 1.4 |
Component: | themes | Version: | 1.4.0b |
Keywords: | soria TabContainer | Cc: | |
Blocked By: | Blocking: |
Description
Setting doLayout="false" in dijit.layout.TabContainer? does not work with the Soria theme. The tab container does not expand vertically to display its contents. This does not seem to be specific to any browser/version/os.
Works fine with Tundra and Nihilo. Soria theme defines a fixed height for the following while Tundra and Nihilo do not.
http://bugs.dojotoolkit.org/browser/dijit/trunk/themes/soria/layout/TabContainer.css
/* top container */
.soria .dijitTabContainerTop-container {
border-top: none;
height: 29px;
}
http://bugs.dojotoolkit.org/browser/dijit/trunk/themes/tundra/layout/TabContainer.css
/* top container */
.tundra .dijitTabContainerTop-container {
border-top: none;
}
http://bugs.dojotoolkit.org/browser/dijit/trunk/themes/nihilo/layout/TabContainer.css
/* top container */
.nihilo .dijitTabContainerTop-container {
border-top: none;
}
Thanks,
Rich Palacios
Change History (2)
comment:1 Changed 13 years ago by
Milestone: | tbd → 1.4 |
---|---|
Owner: | changed from nonken to bill |
Status: | new → assigned |
Summary: | Soria Theme - Setting doLayout="false" in dijit.layout.TabContainer does not work for Soria theme. → [regression] Soria Theme - Setting doLayout="false" in dijit.layout.TabContainer does not work for Soria theme. |
comment:2 Changed 13 years ago by
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
Good catch, the problem shows up in test_TabContainer_noLayout.html?theme=soria (it's pretty unusable). It's from [19739], the scrolling TabContainer patch.
I'll remove that line, it doesn't seem to be needed. Both doLayout=false and doLayout=true work w/out it, at least on FF.