Opened 10 years ago

Closed 6 years ago

#10344 closed task (patchwelcome)

FontChoice, FontSize, Format tests

Reported by: bill Owned by: Jared Jurkiewicz
Priority: low Milestone: future
Component: Editor Version: 1.4.0b
Keywords: Cc:
Blocked By: Blocking:

Description

Add robot tests for the font-size, font, and format drop downs (ie, plugins) in the editor toolbar.

Change History (9)

comment:1 Changed 10 years ago by bill

Milestone: 1.51.4
Resolution: duplicate
Status: newclosed

Oh nevermind, Jared has actually checked in a bunch of tests already, in [20422] (refs #10048). :-)

comment:2 Changed 10 years ago by bill

Milestone: 1.41.5
Resolution: duplicate
Status: closedreopened

Actually, reopening this. There are tests but they are missing important aspects, namely:

  • Check that the setting the font/font-size/format actually does something (ie: modifies the editor content)
  • Check that font/font-size/format can be set via the mouse and the keyboard. The current test just sets the value of the FilteringSelect programatically. Need to check that setting the value via the mouse and keyboard works, and that after setting the value focus is returned to the editor and the selection is still set.

comment:3 Changed 10 years ago by Jared Jurkiewicz

Bill,

Just to be clear, the tests to check that the apply did do something. It alters the content via tne dropdown event, then gets the document to requery state, which checks the underlying dom. If the underlying dom wasn't updated, the state would revert in the filtering select and the test would/should fail.

comment:4 Changed 10 years ago by bill

OK, but I'd rather you directly check that the document was updated. Otherwise the test might report success when it actually failed, for example if requerying the document state failed somehow and thus the FilteringSelect's value wasn't updated.

comment:5 Changed 9 years ago by Adam Peller

Milestone: 1.51.6

comment:6 Changed 9 years ago by Douglas Hays

Owner: set to Jared Jurkiewicz
Status: reopenednew

comment:7 Changed 9 years ago by Jared Jurkiewicz

Milestone: 1.6future

comment:8 Changed 7 years ago by bill

Priority: highlow

comment:9 Changed 6 years ago by bill

Resolution: patchwelcome
Status: newclosed

Unlikely this will be fixed unless someone wants to supply a patch (including a test case).

Note: See TracTickets for help on using tickets.