Opened 10 years ago

Closed 8 years ago

Last modified 7 years ago

#10340 closed task (fixed)

CheckBox/RadioButton: add robot tests

Reported by: bill Owned by: Douglas Hays
Priority: high Milestone: 1.6
Component: Dijit - Form Version: 1.4.0b
Keywords: Cc:
Blocked By: Blocking:

Description

Add robot tests (keyboard and mouse) for checkbox / radio button.

Probably also should have some programmatic tests to make sure that setting the value of one radio button turns off the other radio buttons.

Attachments (1)

CheckBox_Radio_robot.patch (33.3 KB) - added by Katie Vance 8 years ago.
Robot tests for test_CheckBox.html

Download all attachments as: .zip

Change History (13)

comment:1 Changed 9 years ago by Adam Peller

Milestone: 1.51.6

comment:2 Changed 9 years ago by Douglas Hays

dijit/tests/form/test_CheckBox.html contains several inline/programmatic tests.

comment:3 Changed 9 years ago by Douglas Hays

Owner: set to Katie Vance

comment:4 Changed 9 years ago by bill

Yup, there are some programmatic tests already but I don't see any for radio buttons specifically about how clicking one unclicks the others with the same name (but not affecting checkboxes with a different name).

Changed 8 years ago by Katie Vance

Attachment: CheckBox_Radio_robot.patch added

Robot tests for test_CheckBox.html

comment:5 Changed 8 years ago by Katie Vance

Owner: changed from Katie Vance to Douglas Hays

Robot tests are attached.

comment:6 Changed 8 years ago by Douglas Hays

Resolution: fixed
Status: newclosed

(In [23224]) Fixes #10340. Proxy commit for ksv (CCLA). Create CheckBox? a11y and mouse automated tests and move programmatic tests from test_CheckBox.html into CheckBox_a11y.html

comment:7 Changed 8 years ago by Douglas Hays

(In [23336]) Refs #10340. Programmatic test was setting the wrong id attribute causing LABEL to not work and preventing proper focus.

comment:8 Changed 8 years ago by bill

(In [23349]) Fix id mismatch between test_CheckBox.html and !CheckBox_mouse.html, and fix invalid HTML in test_CheckBox.html. Refs #10340.

comment:9 Changed 8 years ago by bill

(In [24032]) Remove weird changes from [23224] expressing arrays like {"0": "foo"} rather than foo?.

This was a workaround to a dojo.toJson() problem on some browsers (but not IE9) when the object passed to dojo.toJson() contains an Array created in a separate frame.

Refs #10340.

comment:10 Changed 8 years ago by bill

(In [24100]) Merge [24032] test fix to 1.6/ branch, refs #10340.

comment:11 Changed 8 years ago by bill

Component: DijitDijit - Form

comment:12 Changed 7 years ago by bill

In [28881]:

Fix duplicate id, refs #10340

Note: See TracTickets for help on using tickets.