Opened 10 years ago

Closed 10 years ago

#10312 closed defect (fixed)

[patch][ccla] Cannot DnD with a 1px move

Reported by: Douglas Hays Owned by: Eugene Lazutkin
Priority: high Milestone: 1.5
Component: DnD Version: 1.4.0b
Keywords: Cc:
Blocked By: Blocking:

Description

When you mousedown to start dragging and move 1px, then Source:onMouseMove is called and startDrag is signaled. However, since the drag has already started, then _markTargetAnchor should have been signaled as well but it isn't until you move another 1px. This can easily be fixed by reordering the onMouseMove code slightly. The resulting problem can be seen by running: ​http://download.dojotoolkit.org/release-1.3.2/dojo-release-1.3.2/dojox/grid/tests/test_grid_column_reorder.html mousedown on Column 3's header and move the mouse just 1px and release the mouse to drop. The drag start icon can be seen, but the drop causes the column to shift to the start of the table since no target anchor was ever selected.

Attachments (1)

10312.patch​ (3.4 KB) - added by Douglas Hays 10 years ago.
simple fix to call _markTargetAnchor after startDrag

Download all attachments as: .zip

Change History (2)

Changed 10 years ago by Douglas Hays

Attachment: 10312.patch​ added

simple fix to call _markTargetAnchor after startDrag

comment:1 Changed 10 years ago by Douglas Hays

Resolution: → fixed
Status: new → closed

(In [21024]) Fixes #10312 !strict. Reorder code to call _marktargetanchor after startdrag without having to wait for further mouse movement. Add automated test to DateGgrid_mouse.html since it was already setup to move columns and was adversely affected by this issue.

Note: See TracTickets for help on using tickets.