#10287 closed task (fixed)
_xhrArg() meaningless parameter
Reported by: | bill | Owned by: | James Burke |
---|---|---|---|
Priority: | low | Milestone: | 1.4 |
Component: | Core | Version: | 1.4.0b |
Keywords: | cc | Cc: | |
Blocked By: | Blocking: |
Description
In the definition of dojo.xhr() there's the line:
var xhr = dfd.ioArgs.xhr = _d._xhrObj(dfd.ioArgs.args);
Apparently _xhrObj() doesn't take any argument.
Also, there are many places in that function definition where dfd.ioArgs is accessed where we could use the local variable ioArgs.
Change History (3)
comment:1 Changed 11 years ago by
Milestone: | tbd → 1.4 |
---|---|
Owner: | changed from anonymous to James Burke |
comment:2 Changed 11 years ago by
Resolution: | → fixed |
---|---|
Status: | new → closed |
comment:3 Changed 11 years ago by
Oops, sorry for the false alarm, didn't notice the comment because I was looking at the output from shrinksafe (with comments stripped; I can't find a way to leave them in).
Note: See
TracTickets for help on using
tickets.
The passing of the args is on purpose, there is a comment above the line explaining why. It allows other code to intercept and give an alternate XHR implementation. I'll fix the dfd.ioArgs calls.