Opened 10 years ago

Closed 9 years ago

Last modified 9 years ago

#10286 closed defect (fixed)

contentsetter missing throw

Reported by: bill Owned by: Sam Foster
Priority: high Milestone: 1.5
Component: HTML Version: 1.4.0b
Keywords: cc Cc:
Blocked By: Blocking:

Description

Shouldn't there be a throw on the Error?

dojo.declare("dojo.html._ContentSetter", null, {
...
	if (!(this.node || node)) {
		new Error(this.declaredClass + ": no node provided to " + this.id);
	}

Change History (7)

comment:1 Changed 10 years ago by dante

Milestone: tbd1.5

comment:2 Changed 9 years ago by Sam Foster

Resolution: fixed
Status: newclosed

(In [22450]) Adding missing 'throw'. Fixes #10286

comment:3 Changed 9 years ago by Sam Foster

Resolution: fixed
Status: closedreopened

Re-opening briefly, as its a valid use-case to instantiate the ContentSetter? with no node property (and the NodeList? extension does just that)

comment:4 Changed 9 years ago by bill

Milestone: 1.51.6

1.5 is released, moving remaining tickets to 1.6

comment:5 Changed 9 years ago by Sam Foster

Resolution: fixed
Status: reopenedclosed

fixed by r22451: | sfoster | 2010-07-07 23:53:17 +0100 (Wed, 07 Jul 2010) | 1 line

Moving throw to set(), where having no .node property is a show-stopper. Instantiating _ContentSetter without a .node is valid as reuse of the setter is encouraged. Fixes #10286

comment:6 Changed 9 years ago by Sam Foster

Note, trac missed this, but it was fixed in 1.5.0

comment:7 Changed 9 years ago by Adam Peller

Milestone: 1.61.5
Note: See TracTickets for help on using tickets.